You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages
Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
Tested basic functionality of all binary files (usually in ./result/bin/)
cabin> Running phase: buildPhase
cabin> build flags: SHELL=/nix/store/5wjj1f3pa1ndi3kvskm1fcs9kdy2xajf-bash-5.2p37/bin/bash RELEASE=1
cabin> /nix/store/5wjj1f3pa1ndi3kvskm1fcs9kdy2xajf-bash-5.2p37/bin/bash: line 1: git: command not found
cabin> /nix/store/5wjj1f3pa1ndi3kvskm1fcs9kdy2xajf-bash-5.2p37/bin/bash: line 1: git: command not found
cabin> /nix/store/5wjj1f3pa1ndi3kvskm1fcs9kdy2xajf-bash-5.2p37/bin/bash: line 1: git: command not found
cabin> Requested 'tbb < 2022.0.0' but version of oneAPI Threading Building Blocks (oneTBB) is 2022.0.0
cabin> You may find new versions of oneAPI Threading Building Blocks (oneTBB) at https://github.com/oneapi-src/oneTBB
cabin> Requested 'tbb < 2022.0.0' but version of oneAPI Threading Building Blocks (oneTBB) is 2022.0.0
cabin> You may find new versions of oneAPI Threading Building Blocks (oneTBB) at https://github.com/oneapi-src/oneTBB
cabin> Error: tbb >= 2021.5.0, tbb < 2022.0.0 not found
cabin> make: *** [Makefile:67: check_deps] Error 1
error: builder for '/nix/store/hsv22z2jxv9s00hp3rvsn1pw2fp5gmzn-cabin-0.11.0.drv' failed with exit code 2;
last 18 log lines:
> Running phase: unpackPhase
> unpacking source archive /nix/store/lv14b5dvzrbydr0xxxk2s4nqq6kn7f32-source
> source root is source
> Running phase: patchPhase
> Running phase: updateAutotoolsGnuConfigScriptsPhase
> Running phase: configurePhase
> no configure script, doing nothing
> Running phase: buildPhase
> build flags: SHELL=/nix/store/5wjj1f3pa1ndi3kvskm1fcs9kdy2xajf-bash-5.2p37/bin/bash RELEASE=1
> /nix/store/5wjj1f3pa1ndi3kvskm1fcs9kdy2xajf-bash-5.2p37/bin/bash: line 1: git: command not found
> /nix/store/5wjj1f3pa1ndi3kvskm1fcs9kdy2xajf-bash-5.2p37/bin/bash: line 1: git: command not found
> /nix/store/5wjj1f3pa1ndi3kvskm1fcs9kdy2xajf-bash-5.2p37/bin/bash: line 1: git: command not found
> Requested 'tbb < 2022.0.0' but version of oneAPI Threading Building Blocks (oneTBB) is 2022.0.0
> You may find new versions of oneAPI Threading Building Blocks (oneTBB) at https://github.com/oneapi-src/oneTBB
> Requested 'tbb < 2022.0.0' but version of oneAPI Threading Building Blocks (oneTBB) is 2022.0.0
> You may find new versions of oneAPI Threading Building Blocks (oneTBB) at https://github.com/oneapi-src/oneTBB
> Error: tbb >= 2021.5.0, tbb < 2022.0.0 not found
> make: *** [Makefile:67: check_deps] Error 1
Running phase: buildPhase
@nix { "action": "setPhase", "phase": "buildPhase" }
build flags: SHELL=/nix/store/5mh7kaj2fyv8mk4sfq1brwxgc02884wi-bash-5.2p37/bin/bash RELEASE=1
/nix/store/5mh7kaj2fyv8mk4sfq1brwxgc02884wi-bash-5.2p37/bin/bash: line 1: git: command not found
/nix/store/5mh7kaj2fyv8mk4sfq1brwxgc02884wi-bash-5.2p37/bin/bash: line 1: git: command not found
/nix/store/5mh7kaj2fyv8mk4sfq1brwxgc02884wi-bash-5.2p37/bin/bash: line 1: git: command not found
\#git clone https://github.com/ToruNiina/toml11.git build/DEPS/toml11
/nix/store/5mh7kaj2fyv8mk4sfq1brwxgc02884wi-bash-5.2p37/bin/bash: line 1: #git: command not found
make: *** [Makefile:136: build/DEPS/toml11] Error 127
Names in the nixpkgs top level namespace are generally first-come-first-serve, so it's not appropriate for you to evict another project using a name because you changed your project to that name.
Would you be okay with updating this PR to use the name cabinpkg?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.