Skip to content

cabinpkg: 0.10.1 -> 0.11.0, renamed from poac#371042

Merged
rhelmot merged 1 commit intoNixOS:masterfrom
ken-matsui:poac-cabin-0.11.0
Jan 23, 2025
Merged

cabinpkg: 0.10.1 -> 0.11.0, renamed from poac#371042
rhelmot merged 1 commit intoNixOS:masterfrom
ken-matsui:poac-cabin-0.11.0

Conversation

@ken-matsui
Copy link
Member

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: documentation This PR adds or changes documentation 8.has: changelog This PR adds or changes release notes 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Jan 5, 2025
@nix-owners nix-owners bot requested a review from cmfwyp January 5, 2025 02:31
@uncenter
Copy link
Member

uncenter commented Jan 6, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 371042


aarch64-darwin

❌ 1 package failed to build:
  • cabin
✅ 1 package built:
  • cabin-fonts
cabin> Running phase: buildPhase
cabin> build flags: SHELL=/nix/store/5wjj1f3pa1ndi3kvskm1fcs9kdy2xajf-bash-5.2p37/bin/bash RELEASE=1
cabin> /nix/store/5wjj1f3pa1ndi3kvskm1fcs9kdy2xajf-bash-5.2p37/bin/bash: line 1: git: command not found
cabin> /nix/store/5wjj1f3pa1ndi3kvskm1fcs9kdy2xajf-bash-5.2p37/bin/bash: line 1: git: command not found
cabin> /nix/store/5wjj1f3pa1ndi3kvskm1fcs9kdy2xajf-bash-5.2p37/bin/bash: line 1: git: command not found
cabin> Requested 'tbb < 2022.0.0' but version of oneAPI Threading Building Blocks (oneTBB) is 2022.0.0
cabin> You may find new versions of oneAPI Threading Building Blocks (oneTBB) at https://github.com/oneapi-src/oneTBB
cabin> Requested 'tbb < 2022.0.0' but version of oneAPI Threading Building Blocks (oneTBB) is 2022.0.0
cabin> You may find new versions of oneAPI Threading Building Blocks (oneTBB) at https://github.com/oneapi-src/oneTBB
cabin> Error: tbb >= 2021.5.0, tbb < 2022.0.0 not found
cabin> make: *** [Makefile:67: check_deps] Error 1
error: builder for '/nix/store/hsv22z2jxv9s00hp3rvsn1pw2fp5gmzn-cabin-0.11.0.drv' failed with exit code 2;
       last 18 log lines:
       > Running phase: unpackPhase
       > unpacking source archive /nix/store/lv14b5dvzrbydr0xxxk2s4nqq6kn7f32-source
       > source root is source
       > Running phase: patchPhase
       > Running phase: updateAutotoolsGnuConfigScriptsPhase
       > Running phase: configurePhase
       > no configure script, doing nothing
       > Running phase: buildPhase
       > build flags: SHELL=/nix/store/5wjj1f3pa1ndi3kvskm1fcs9kdy2xajf-bash-5.2p37/bin/bash RELEASE=1
       > /nix/store/5wjj1f3pa1ndi3kvskm1fcs9kdy2xajf-bash-5.2p37/bin/bash: line 1: git: command not found
       > /nix/store/5wjj1f3pa1ndi3kvskm1fcs9kdy2xajf-bash-5.2p37/bin/bash: line 1: git: command not found
       > /nix/store/5wjj1f3pa1ndi3kvskm1fcs9kdy2xajf-bash-5.2p37/bin/bash: line 1: git: command not found
       > Requested 'tbb < 2022.0.0' but version of oneAPI Threading Building Blocks (oneTBB) is 2022.0.0
       > You may find new versions of oneAPI Threading Building Blocks (oneTBB) at https://github.com/oneapi-src/oneTBB
       > Requested 'tbb < 2022.0.0' but version of oneAPI Threading Building Blocks (oneTBB) is 2022.0.0
       > You may find new versions of oneAPI Threading Building Blocks (oneTBB) at https://github.com/oneapi-src/oneTBB
       > Error: tbb >= 2021.5.0, tbb < 2022.0.0 not found
       > make: *** [Makefile:67: check_deps] Error 1

@uncenter
Copy link
Member

uncenter commented Jan 6, 2025

Also fwiw it seems like the build is still producing a binary called poac, not cabin?

@ken-matsui
Copy link
Member Author

ken-matsui commented Jan 6, 2025

Thanks for your review.

Also fwiw it seems like the build is still producing a binary called poac, not cabin?

It should produce cabin, not poac. I guess this is because I forgot to update the SHA 256, fixed it with the new commit.

@uncenter
Copy link
Member

uncenter commented Jan 6, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 371042


x86_64-linux

⏩ 2 packages blacklisted:
  • nixos-install-tools
  • tests.nixos-functions.nixos-test
❌ 1 package failed to build:
  • cabin
✅ 1 package built:
  • cabin-fonts
Running phase: buildPhase
@nix { "action": "setPhase", "phase": "buildPhase" }
build flags: SHELL=/nix/store/5mh7kaj2fyv8mk4sfq1brwxgc02884wi-bash-5.2p37/bin/bash RELEASE=1
/nix/store/5mh7kaj2fyv8mk4sfq1brwxgc02884wi-bash-5.2p37/bin/bash: line 1: git: command not found
/nix/store/5mh7kaj2fyv8mk4sfq1brwxgc02884wi-bash-5.2p37/bin/bash: line 1: git: command not found
/nix/store/5mh7kaj2fyv8mk4sfq1brwxgc02884wi-bash-5.2p37/bin/bash: line 1: git: command not found
\#git clone https://github.com/ToruNiina/toml11.git build/DEPS/toml11
/nix/store/5mh7kaj2fyv8mk4sfq1brwxgc02884wi-bash-5.2p37/bin/bash: line 1: #git: command not found
make: *** [Makefile:136: build/DEPS/toml11] Error 127

@ken-matsui ken-matsui requested a review from uncenter January 6, 2025 03:28
@ken-matsui
Copy link
Member Author

@uncenter Would you be able to backport a085732b625e91f3420c32e423dc4d57d3aaf88b to existing releases? The font Cabin is a bit confusing to my users: https://docs.cabinpkg.com/installation/.

@uncenter
Copy link
Member

uncenter commented Jan 6, 2025

I'm not familiar with backports sorry, someone else would have to take a look.

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 371042


x86_64-linux

✅ 2 packages built:
  • cabin
  • cabin-fonts

@uncenter
Copy link
Member

uncenter commented Jan 6, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 371042


aarch64-darwin

✅ 2 packages built:
  • cabin
  • cabin-fonts

@isabelroses
Copy link
Member

@uncenter Would you be able to backport a085732 to existing releases? The font Cabin is a bit confusing to my users: docs.cabinpkg.com/installation.

That would be a breaking change without an alias, meaning it cannot be back-ported to the 24.05 release.

@rhelmot
Copy link
Contributor

rhelmot commented Jan 22, 2025

Names in the nixpkgs top level namespace are generally first-come-first-serve, so it's not appropriate for you to evict another project using a name because you changed your project to that name.

Would you be okay with updating this PR to use the name cabinpkg?

@ken-matsui
Copy link
Member Author

That's totally fine, thank you for the info :)

@github-actions github-actions bot added the 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. label Jan 23, 2025
@uncenter
Copy link
Member

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 371042


aarch64-darwin

✅ 1 package built:
  • cabinpkg

@ken-matsui ken-matsui changed the title cabin: 0.10.1 -> 0.11.0, renamed from poac cabinpkg: 0.10.1 -> 0.11.0, renamed from poac Jan 23, 2025
@uncenter uncenter added the 12.approvals: 1 This PR was reviewed and approved by one person. label Jan 23, 2025
@rhelmot rhelmot merged commit 9f72062 into NixOS:master Jan 23, 2025
32 of 34 checks passed
@ken-matsui ken-matsui deleted the poac-cabin-0.11.0 branch January 23, 2025 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: changelog This PR adds or changes release notes 8.has: documentation This PR adds or changes documentation 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants