Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

badchars: 0.4.0 -> 0.5.0 #371253

Merged
merged 4 commits into from
Jan 11, 2025
Merged

badchars: 0.4.0 -> 0.5.0 #371253

merged 4 commits into from
Jan 11, 2025

Conversation

fabaff
Copy link
Member

@fabaff fabaff commented Jan 5, 2025

Diff: cytopia/badchars@refs/tags/0.4.0...0.5.0

Changelog: https://github.com/cytopia/badchars/releases/tag/0.5.0

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@fabaff
Copy link
Member Author

fabaff commented Jan 5, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 371253


x86_64-linux

✅ 2 packages built:
  • badchars
  • badchars.dist

@lucasew
Copy link
Contributor

lucasew commented Jan 6, 2025

Can you move it to pkgs/by-name?

@lucasew
Copy link
Contributor

lucasew commented Jan 6, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 371253


x86_64-linux

✅ 2 packages built:
  • badchars
  • badchars.dist

@fabaff fabaff force-pushed the badchars-bump branch 2 times, most recently from bd3a190 to 81f6b2e Compare January 9, 2025 09:49
@fabaff fabaff merged commit 0a85603 into NixOS:master Jan 11, 2025
24 of 27 checks passed
@fabaff fabaff deleted the badchars-bump branch January 11, 2025 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants