Skip to content

jwt-cli: refactor #371254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 10, 2025
Merged

jwt-cli: refactor #371254

merged 4 commits into from
Jan 10, 2025

Conversation

fabaff
Copy link
Member

@fabaff fabaff commented Jan 5, 2025

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Jan 5, 2025
@fabaff

This comment was marked as outdated.

Sign in to view
@lucasew
Copy link
Contributor

lucasew commented Jan 6, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 371254

@lucasew
Copy link
Contributor

lucasew commented Jan 9, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 371254

@lucasew
Copy link
Contributor

lucasew commented Jan 9, 2025

Diff LGTM, for linux seems like it's a noop.

@lucasew lucasew requested a review from GaetanLepage January 9, 2025 13:50
@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Jan 9, 2025
@GaetanLepage
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 371254

x86_64-darwin

✅ 1 package built:
  • jwt-cli

aarch64-darwin

✅ 1 package built:
  • jwt-cli

GaetanLepage
GaetanLepage approved these changes Jan 10, 2025
View reviewed changes
Copy link
Contributor

@GaetanLepage GaetanLepage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @fabaff

@github-actions github-actions bot added 10.rebuild-darwin: 1-10 and removed 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin labels Jan 10, 2025
@fabaff fabaff merged commit 113da45 into NixOS:master Jan 10, 2025
23 of 27 checks passed
@fabaff fabaff deleted the jwt-cli-refactor branch January 10, 2025 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucasew lucasew lucasew approved these changes

@GaetanLepage GaetanLepage GaetanLepage approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fabaff @lucasew @GaetanLepage @wegank