Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/lubelogger: init #371458

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

nixos/lubelogger: init #371458

wants to merge 2 commits into from

Conversation

bct
Copy link
Contributor

@bct bct commented Jan 6, 2025

Adds a module for LubeLogger, and adds myself as maintainer.

Closes #333954

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` labels Jan 6, 2025
@bct
Copy link
Contributor Author

bct commented Jan 6, 2025

This is mostly #335653 , with a few modifications:

  • fixes "cannot coerce integer to a string"
  • adds an environmentFile option, for setting sensitive environment variables
  • updates the /var/lib/lubelogger/wwwroot symlinks when the nix package is updated
  • hardens the systemd configuration

@bct bct force-pushed the lubelogger-module branch from 9486491 to b9d457b Compare January 6, 2025 14:26
@nix-owners nix-owners bot requested a review from Lyndeno January 6, 2025 14:26
@bct bct changed the title Lubelogger module nixos/lubelogger: init Jan 6, 2025
@Lyndeno
Copy link
Contributor

Lyndeno commented Jan 6, 2025

I'll have a look at this later, I am happy to also be added to the maintainers field for the module.

@bct
Copy link
Contributor Author

bct commented Jan 6, 2025

👍 Only changed the maintainer because I wasn't sure you were still up for it.

Unfortunately I pulled at a thread and discovered that this module is not working correctly. Configuration changes get lost when the service is restarted - it's loading userConfig from the ContentRoot in the /nix/store, not from /var/lib/lubelogger.

I've put up a PR for this issue here: hargata/lubelog#781

@bct bct force-pushed the lubelogger-module branch from b9d457b to 974d0a1 Compare January 9, 2025 05:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lubelogger runs but several features (image & document uploads, authentication, etc.) are non-functional
2 participants