Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bat: 0.24.0 -> 0.25.0 #371913

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

bat: 0.24.0 -> 0.25.0 #371913

wants to merge 3 commits into from

Conversation

will
Copy link
Contributor

@will will commented Jan 7, 2025

bat 0.25.0 was released today: https://github.com/sharkdp/bat/releases/tag/v0.25.0

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@will
Copy link
Contributor Author

will commented Jan 7, 2025

Oh hmm

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review


aarch64-darwin

❌ 2 packages failed to build:
  • bat-extras.batgrep
  • bat-extras.batpipe
✅ 7 packages built:
  • bat
  • bat-extras.batdiff
  • bat-extras.batman
  • bat-extras.batwatch
  • bat-extras.prettybat
  • fzf-git-sh
  • fzf-make
tests for those two failed, here's the test output:
error: builder for '/nix/store/ddkhgq9zjgmzsmypfzn1g67ap4nwkhy7-batpipe-2024.07.10.drv' failed with exit code 2;
       last 19 log lines:
       > Running phase: unpackPhase
       > unpacking source archive /nix/store/dzpxvlimqy8dafipmlp04yp6v8pssyx5-bat-extras-2024.07.10
       > source root is bat-extras-2024.07.10
       > Running phase: patchPhase
       > patching script interpreter paths in bin/batpipe
       > bin/batpipe: interpreter directive changed from "#!/usr/bin/env bash" to "/nix/store/5wjj1f3pa1ndi3kvskm1fcs9kdy2xajf-bash-5.2p37/bin/bash"
       > Running phase: updateAutotoolsGnuConfigScriptsPhase
       > Running phase: checkPhase
       > --------------------------------------------------------------------------------
       > | Test Suite: batpipe                                                          |
       > --------------------------------------------------------------------------------
       > [FAIL] batpipe_term_width   :: Mismatched STDOUT snapshot.
       > [PASS] detected_bash_shell  :: 911 ms
       > [PASS] detected_fish_shell  :: 1953 ms
       > [PASS] viewer_gzip          :: 1674 ms
       >
       > Totals:
       >     PASS: 3 / 4
       >     FAIL: 1 / 4
       For full logs, run 'nix log /nix/store/ddkhgq9zjgmzsmypfzn1g67ap4nwkhy7-batpipe-2024.07.10.drv'.
error: builder for '/nix/store/w16qss4v19rbp5aa8k6142f0dxk8js0m-batgrep-2024.07.10.drv' failed with exit code 2;
       last 28 log lines:
       > Running phase: unpackPhase
       > unpacking source archive /nix/store/dzpxvlimqy8dafipmlp04yp6v8pssyx5-bat-extras-2024.07.10
       > source root is bat-extras-2024.07.10
       > Running phase: patchPhase
       > patching script interpreter paths in bin/batgrep
       > bin/batgrep: interpreter directive changed from "#!/usr/bin/env bash" to "/nix/store/5wjj1f3pa1ndi3kvskm1fcs9kdy2xajf-bash-5.2p37/bin/bash"
       > Running phase: updateAutotoolsGnuConfigScriptsPhase
       > Running phase: checkPhase
       > --------------------------------------------------------------------------------
       > | Test Suite: batgrep                                                          |
       > --------------------------------------------------------------------------------
       > [PASS] help                 :: 2009 ms
       > [PASS] option_context       :: 1426 ms
       > [FAIL] output_with_color    :: Mismatched STDOUT snapshot.
       > [PASS] output_without_color :: 1510 ms
       > [FAIL] output_without_separator :: Mismatched STDOUT snapshot.
       > [PASS] regular_file         :: 1412 ms
       > [FAIL] respects_bat_style   :: Mismatched STDOUT snapshot.
       > [PASS] sanity_rg_works      :: 78 ms
       > [PASS] search_fixed         :: 1599 ms
       > [PASS] search_from_stdin    :: 1451 ms
       > [PASS] search_regex         :: 1413 ms
       > [PASS] symlink_file         :: 632 ms
       > [PASS] version              :: 672 ms
       >
       > Totals:
       >     PASS: 10 / 13
       >     FAIL: 3 / 13
       For full logs, run 'nix log /nix/store/w16qss4v19rbp5aa8k6142f0dxk8js0m-batgrep-2024.07.10.drv'.
error: 2 dependencies of derivation '/nix/store/k9whmhyqsbracwiil1gf8x0gi70shbmw-review-shell.drv' failed to build


2 packages failed to build:
bat-extras.batgrep bat-extras.batpipe

https://github.com/eth-p/bat-extras looks like no commits for the last 5 months, so nothing to update to at this time. Should it be marked as broken? @bbigras what do you think?

@ddogfoodd
Copy link

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 371913


x86_64-linux

❌ 2 packages failed to build:
  • bat-extras.batgrep
  • bat-extras.batpipe
✅ 8 packages built:
  • bat
  • bat-extras.batdiff
  • bat-extras.batman
  • bat-extras.batwatch
  • bat-extras.prettybat
  • ctpv
  • fzf-git-sh
  • fzf-make

@SuperSandro2000
Copy link
Member

Please mark bat-extras broken for now.

@will
Copy link
Contributor Author

will commented Jan 8, 2025

Please mark bat-extras broken for now.

Alright. Added a second patch for this, but I can squash it into the first if that's more appropriate.

@nix-owners nix-owners bot requested a review from bbigras January 8, 2025 16:34
@Adda0
Copy link
Contributor

Adda0 commented Jan 9, 2025

I am not sure which approach is more appropriate, but the release adds the classic --completion <shell> option to generate completions. Would it be better than our current approach?

@SuperSandro2000
Copy link
Member

The current approach works better with cross.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants