-
-
Notifications
You must be signed in to change notification settings - Fork 14.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
freerouting: init at 2.0.1 #371943
base: master
Are you sure you want to change the base?
freerouting: init at 2.0.1 #371943
Conversation
d169aeb
to
ad4737f
Compare
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/5057 |
c96a62e
to
61c09b6
Compare
@GaetanLepage many thanks for the review and suggestions, have updated the commit with your suggestions and added and attribution for you. |
|
Co-authored-by: Gaétan Lepage <GaetanLepage@users.noreply.github.com>
61c09b6
to
8475023
Compare
longDescription = '' | ||
Freerouting is an advanced autorouter for all PCB programs that support | ||
the standard Specctra or Electra DSN interface. ''; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
longDescription = '' | |
Freerouting is an advanced autorouter for all PCB programs that support | |
the standard Specctra or Electra DSN interface. ''; | |
longDescription = '' | |
Freerouting is an advanced autorouter for all PCB programs that support | |
the standard Specctra or Electra DSN interface. | |
''; |
I'm surprised that this is not enforced by nixfmt
... I don't think it is valid formatting.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I must've hit shift+j and not realised at some point along the way as it was previously correct in 0bd675f
|
Fails on darwin with:
I cannot really help you on this... Maybe ask for help on the JVM matrix channel. |
Time to get the Macbook back out, it built and ran fine yesterday but I'll have another look. |
Add Freerouting, a useful program for automatically generating PCB traces.
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.