Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

freerouting: init at 2.0.1 #371943

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

srounce
Copy link
Contributor

@srounce srounce commented Jan 7, 2025

Add Freerouting, a useful program for automatically generating PCB traces.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Jan 7, 2025
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/5057

pkgs/by-name/fr/freerouting/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/fr/freerouting/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/fr/freerouting/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/fr/freerouting/package.nix Outdated Show resolved Hide resolved
@srounce srounce force-pushed the init-freerouting branch 3 times, most recently from c96a62e to 61c09b6 Compare January 8, 2025 15:11
@srounce
Copy link
Contributor Author

srounce commented Jan 8, 2025

@GaetanLepage many thanks for the review and suggestions, have updated the commit with your suggestions and added and attribution for you.

@GaetanLepage
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 371943

Co-authored-by: Gaétan Lepage <GaetanLepage@users.noreply.github.com>
@github-actions github-actions bot added 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 and removed 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Jan 8, 2025
Comment on lines +50 to +52
longDescription = ''
Freerouting is an advanced autorouter for all PCB programs that support
the standard Specctra or Electra DSN interface. '';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
longDescription = ''
Freerouting is an advanced autorouter for all PCB programs that support
the standard Specctra or Electra DSN interface. '';
longDescription = ''
Freerouting is an advanced autorouter for all PCB programs that support
the standard Specctra or Electra DSN interface.
'';

I'm surprised that this is not enforced by nixfmt... I don't think it is valid formatting.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I must've hit shift+j and not realised at some point along the way as it was previously correct in 0bd675f

@GaetanLepage
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 371943


x86_64-linux

✅ 1 package built:
  • freerouting

aarch64-linux

✅ 1 package built:
  • freerouting

x86_64-darwin

❌ 1 package failed to build:
  • freerouting

aarch64-darwin

❌ 1 package failed to build:
  • freerouting

@GaetanLepage
Copy link
Contributor

Fails on darwin with:

FAILURE: Build failed with an exception.

* What went wrong:
Could not connect to the Gradle daemon.
Daemon uid: 653de0f8-27bb-46ff-ae67-e2a6fe7a8dc6 with diagnostics:
Daemon pid: 57193
  log file: /private/tmp/nix-build-freerouting-2.0.1.drv-0/tmp.sLoEo5zA1D/daemon/8.10.2/daemon-57193.out.log
----- Last 20 lines from daemon log file - daemon-57193.out.log -----
2025-01-08T15:59:56.597+0000 [DEBUG] [org.gradle.internal.remote.internal.inet.InetAddresses] Is this a loopback interface? true
2025-01-08T15:59:56.597+0000 [DEBUG] [org.gradle.internal.remote.internal.inet.InetAddresses] Ignoring remote address on loopback interface /fe80:0:0:0:0:0:0:1%lo0
2025-01-08T15:59:56.597+0000 [DEBUG] [org.gradle.internal.remote.internal.inet.InetAddresses] Adding loopback address /0:0:0:0:0:0:0:1%lo0
2025-01-08T15:59:56.597+0000 [DEBUG] [org.gradle.internal.remote.internal.inet.InetAddresses] Adding loopback address /127.0.0.1
2025-01-08T15:59:56.600+0000 [DEBUG] [org.gradle.internal.remote.internal.inet.TcpIncomingConnector] Listening on [d2ebafb0-e04b-4e15-aac2-226e3417a701 port:51399, addresses:[localh>
2025-01-08T15:59:56.606+0000 [DEBUG] [org.gradle.launcher.daemon.server.Daemon] Daemon starting at: Wed Jan 08 15:59:56 UTC 2025, with address: [d2ebafb0-e04b-4e15-aac2-226e3417a701>
2025-01-08T15:59:56.607+0000 [INFO] [org.gradle.launcher.daemon.server.DaemonRegistryUpdater] Advertising the daemon address to the clients: [d2ebafb0-e04b-4e15-aac2-226e3417a701 po>
2025-01-08T15:59:56.607+0000 [DEBUG] [org.gradle.launcher.daemon.server.DaemonRegistryUpdater] Advertised daemon context: DefaultDaemonContext[uid=653de0f8-27bb-46ff-ae67-e2a6fe7a8d>
2025-01-08T15:59:56.608+0000 [DEBUG] [org.gradle.launcher.daemon.registry.PersistentDaemonRegistry] Storing daemon address: [d2ebafb0-e04b-4e15-aac2-226e3417a701 port:51399, address>
2025-01-08T15:59:56.624+0000 [DEBUG] [org.gradle.cache.internal.DefaultFileLockManager] Waiting to acquire exclusive lock on daemon addresses registry.
2025-01-08T15:59:56.646+0000 [DEBUG] [org.gradle.cache.internal.DefaultFileLockManager] Lock acquired on daemon addresses registry.
2025-01-08T15:59:56.650+0000 [DEBUG] [org.gradle.cache.internal.DefaultFileLockManager] Releasing lock on daemon addresses registry.
2025-01-08T15:59:56.653+0000 [DEBUG] [org.gradle.cache.internal.DefaultFileLockManager] Waiting to acquire exclusive lock on daemon addresses registry.
2025-01-08T15:59:56.653+0000 [DEBUG] [org.gradle.cache.internal.DefaultFileLockManager] Lock acquired on daemon addresses registry.
2025-01-08T15:59:56.656+0000 [DEBUG] [org.gradle.cache.internal.DefaultFileLockManager] Releasing lock on daemon addresses registry.
2025-01-08T15:59:56.656+0000 [LIFECYCLE] [org.gradle.launcher.daemon.server.Daemon] Daemon server started.
2025-01-08T15:59:56.666+0000 [DEBUG] [org.gradle.launcher.daemon.bootstrap.DaemonStartupCommunication] Completed writing the daemon greeting. Closing streams...
2025-01-08T15:59:56.674+0000 [DEBUG] [org.gradle.launcher.daemon.server.Daemon] stopOnExpiration() called on daemon
2025-01-08T15:59:56.682+0000 [DEBUG] [org.gradle.launcher.daemon.server.Daemon] awaitExpiration() called on daemon
2025-01-08T15:59:56.682+0000 [DEBUG] [org.gradle.launcher.daemon.server.DaemonStateCoordinator] daemon is running. Sleeping until state changes.----- End of the daemon log -----

I cannot really help you on this... Maybe ask for help on the JVM matrix channel.

@srounce
Copy link
Contributor Author

srounce commented Jan 8, 2025

Time to get the Macbook back out, it built and ran fine yesterday but I'll have another look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants