Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lha: unstable-2021-01-07 -> unstable-2024-11-27 #372014

Merged
merged 2 commits into from
Jan 14, 2025
Merged

Conversation

momeemt
Copy link
Member

@momeemt momeemt commented Jan 8, 2025

Closes #370358

  • Updated lha from unstable-2021-01-07 to unstable-2024-11-27
  • Removed with lib;.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@momeemt
Copy link
Member Author

momeemt commented Jan 8, 2025

Result of nixpkgs-review pr 372014 run on x86_64-linux 1

@Frontear
Copy link
Member

Frontear commented Jan 9, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 372014


x86_64-linux

✅ 1 package built:
  • lha

pkgs/by-name/lh/lha/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/lh/lha/package.nix Show resolved Hide resolved
pkgs/by-name/lh/lha/package.nix Show resolved Hide resolved
@natsukium
Copy link
Member

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 372014


x86_64-linux

✅ 1 package built:
  • lha

aarch64-linux

✅ 1 package built:
  • lha

x86_64-darwin

✅ 1 package built:
  • lha

aarch64-darwin

✅ 1 package built:
  • lha

Copy link
Member

@natsukium natsukium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@natsukium natsukium merged commit 061a735 into NixOS:master Jan 14, 2025
24 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build failure: lha
3 participants