Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

linphone: symlink sounds #372140

Merged
merged 1 commit into from
Jan 9, 2025
Merged

linphone: symlink sounds #372140

merged 1 commit into from
Jan 9, 2025

Conversation

FriedrichAltheide
Copy link
Contributor

linphone: symlink sounds

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Jan 8, 2025
@nix-owners nix-owners bot requested a review from jluttine January 8, 2025 13:49
@jluttine
Copy link
Member

jluttine commented Jan 8, 2025

Thanks! I haven't really used Linphone in a long time (or almost at all). Does this PR fix some issue with the current packaging? For instance, without this PR, sounds in Linphone don't work at all?

This closed issue is probably related, maybe this PR fixes that: #219555

@FriedrichAltheide
Copy link
Contributor Author

Yes this PR should be a fix for #219555

jluttine
jluttine approved these changes Jan 8, 2025
View reviewed changes
Copy link
Member

@jluttine jluttine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wasn't able to log into my Linphone account, so I couldn't now easily test this. Anyway, looks good to me. 👍 Thanks!

@wegank wegank added 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package labels Jan 8, 2025
@NickCao NickCao merged commit 658fcd2 into NixOS:master Jan 9, 2025
25 of 29 checks passed
@FriedrichAltheide FriedrichAltheide added the backport release-24.11 Backport PR automatically label Jan 9, 2025
@nixpkgs-ci
Copy link
Contributor

nixpkgs-ci bot commented Jan 9, 2025

Successfully created backport PR for release-24.11:

@nixpkgs-ci nixpkgs-ci bot mentioned this pull request Jan 9, 2025
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NickCao NickCao NickCao approved these changes

@jluttine jluttine jluttine approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package backport release-24.11 Backport PR automatically
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@FriedrichAltheide @jluttine @NickCao @wegank