Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prosody: 0.12.4 → 0.12.5 + community modules #372300

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

toastal
Copy link
Contributor

@toastal toastal commented Jan 9, 2025

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

1

Footnotes

  1. Please consider giving up MS GitHub or offering a non-proprietary, non-US-corporate-controlled mirror for this free software project. I wish to delete this Microsoft account in the future, but I need more projects like this to support alternative methods to send patches & contribute.

@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Jan 9, 2025
@pbsds
Copy link
Member

pbsds commented Jan 15, 2025

Please reword 5c20a25 to prefix which package it formats. Also please omit the word "horrible" in favor of something less ad hominem. I don't mind you expressing dislike for the new format, but try and not assign vague qualities. :)

@toastal toastal force-pushed the prosody-0.12.5 branch 2 times, most recently from 5b120c6 to bbbe250 Compare January 15, 2025 15:53
Apply the needlessly-vertical, doesn’t-fit-on-my-screen formatting
prescribed by `nixfmt`. RIP cuddled `with` statements & condensed,
single-line lists/attrsets that make certain code blocks easier to scan
according to the subjective legibility opinions of the writer for the
reader.
@toastal toastal requested a review from pbsds January 15, 2025 15:58
@toastal
Copy link
Contributor Author

toastal commented Jan 15, 2025

@pbsds more eloquent

@pbsds
Copy link
Member

pbsds commented Jan 17, 2025

It seems the nixos tests break

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants