Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libsixel: fix CVE-2021-45340 #372312

Merged

Conversation

hzeller
Copy link
Contributor

@hzeller hzeller commented Jan 9, 2025

Fixes: #160670

Also, while at it, adopt abandoned package.

Fix tested:

wget https://github.com/libsixel/libsixel/files/7715065/stbi_1561_poc.zip
unzip stbi_1561_poc.zip

# Before: this will result in a core-dump
nix-shell -p libsixel --run "img2sixel ./stbi_1561_poc.bin"

# After: build this patched version - emits proper error message
nix-build -A libsixel
result/bin/img2sixel ./stbi_1561_poc.bin

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@hzeller
Copy link
Contributor Author

hzeller commented Jan 9, 2025

Additional context
libsixel/libsixel#51
libsixel/libsixel#73

@hzeller hzeller requested a review from Mic92 January 9, 2025 08:33
@FliegendeWurst FliegendeWurst merged commit d92f98e into NixOS:master Jan 9, 2025
23 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vulnerability roundup 111: libsixel-1.10.3: 1 advisory [6.5]
2 participants