git-evtag: init at 2022.1 #372317
Open
git-evtag: init at 2022.1 #372317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://github.com/cgwalters/git-evtag This is used for tagging GNOME releases: https://handbook.gnome.org/maintainers/making-a-release.html#tagging-as-the-signal-for-the-release
eljamm
approved these changes
Jan 9, 2025
There was a problem hiding this comment.
nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review pr 372317
x86_64-linux
✅ 1 package built:
- git-evtag
x86_64-darwin
✅ 1 package built:
- git-evtag
aarch64-darwin
✅ 1 package built:
- git-evtag
eljamm
added
the
12.approvals: 1
Defelo
reviewed
Jan 9, 2025
| libgit2, | ||
| }: | ||
|
|
||
| stdenv.mkDerivation rec { |
There was a problem hiding this comment.
Suggested change
| stdenv.mkDerivation rec { | |
| stdenv.mkDerivation (finalAttrs: { |
| src = fetchFromGitHub { | ||
| owner = "cgwalters"; | ||
| repo = "git-evtag"; | ||
| rev = "v${version}"; |
There was a problem hiding this comment.
Suggested change
| rev = "v${version}"; | |
| tag = "v${finalAttrs.version}"; |
|
|
||
| meta = { | ||
| description = "Extended verification for git tags"; | ||
| homepage = "https://github.com/cgwalters/git-evtag"; |
There was a problem hiding this comment.
Suggested change
| homepage = "https://github.com/cgwalters/git-evtag"; | |
| homepage = "https://github.com/cgwalters/git-evtag"; | |
| changelog = "https://github.com/cgwalters/git-evtag/releases/tag/v${finalAttrs.version}"; |
| glib | ||
| libgit2 | ||
| ]; | ||
|
|
There was a problem hiding this comment.
Suggested change
| nativeInstallCheckInputs = [ versionCheckHook ]; | |
| versionCheckProgramArg = "--version"; | |
| doInstallCheck = true; | |
| passthru.updateScript = nix-update-script { }; | |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/cgwalters/git-evtag
This is used for tagging GNOME releases:
https://handbook.gnome.org/maintainers/making-a-release.html#tagging-as-the-signal-for-the-release
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.