-
-
Notifications
You must be signed in to change notification settings - Fork 18k
treewide: remove "with lib;" from meta #373573
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
14 tasks
4ee6104 to
57b9545
Compare
13 tasks
57b9545 to
c414934
Compare
d0637ed to
2a75f93
Compare
2 tasks
2a75f93 to
1c23168
Compare
13 tasks
Contributor
|
This has over 44k lines changed. This is impossible to review like this. How did you create this? Is there code that you can share to reproduce this, so that this can be validated? |
Contributor
Also code/commands to easily verify this claim would be appreciated! |
Contributor
|
Superseded by #443046. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
2.status: merge conflict
This PR has merge conflicts with the target branch
6.topic: cinnamon
Desktop environment
6.topic: docker tools
Open-source software for deploying and running of containerized applications
6.topic: jupyter
Interactive computing tooling: kernels, notebook, jupyterlab
6.topic: qt/kde
Object-oriented framework for GUI creation
6.topic: vim
Advanced text editor
6.topic: vscode
A free and versatile code editor that supports almost every major programming language.
10.rebuild-darwin: 0
This PR does not cause any packages to rebuild on Darwin.
10.rebuild-linux: 0
This PR does not cause any packages to rebuild on Linux.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes a lot of packages treewide to remove the
with lib;pattern frommeta.This removes one
withscope. Furthermore, in many PRs that add a package there is a review that asks for adding or removingwith lib;from themetaexpression (I encountered both requests). It would be more efficient if there was one way to writemetaon which we can all agree. There is https://nix.dev/guides/best-practices.html#with-scopes stating thatwithscopes should not be used for large scopes.metacould be considered a small scope, though.There is also the opposite done in #373548. Of course, it only makes sense to merge either this PR or the other one. I can live with either choice, but the codebase should reflect that choice (which is what this PR aims for), and it should be documented.
For now, I only consider
.nixfiles that are already formatted withnixfmt.Things done
metaattr they touch unchanged.nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.