-
-
Notifications
You must be signed in to change notification settings - Fork 14.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
open-policy-agent: 0.70.0 -> 1.0.1 #374272
base: master
Are you sure you want to change the base?
Conversation
It seems that the bot did pick it up, but there were some issues with the update. Feel free to have a look at the logs, if interested. |
Oh interesting, it looks like the |
Hey @teutat3s! I opened this PR to get the OPA package updated, but it seems there's an issue with the |
Hi @charlieegan3 If you could make a couple of changes that'd be great:
|
b6bfba6
to
36a527b
Compare
Signed-off-by: Charlie Egan <charlieegan3@users.noreply.github.com>
36a527b
to
b6a7ae2
Compare
Thanks @06kellyjac! appreciate it. My guess is that some updates to that package will be required, happy to help there but just not had time to work out what's going on in the project yet. Happy to spend some time next week on it if needs be. I've updated this PR to be 1.0.1 and added release note too. I left the note as v1.0.0+ since there might be some follow on minor releases before the nixpkgs release goes out. |
Unsure what to do about #369555 in the meantime. |
We can ignore the bot PR for now or draft it. 🙂 The build error is due to the v0 v1 migration. We can either try pull the commits which move to element-hq/matrix-authentication-service@881c6df Or I can make a separte patch just based on the |
Cool, good that they've already done the upgrade to v1. That at least makes things a bit easier.
If this is an option, it seems like a good one. Or we could encourage them to cut a release with those Rego changes too? |
Here's a standalone patch if you want: https://gist.github.com/06kellyjac/7038b3d0826f1a1dcae57044a4521260 . Up to you 🙂 Id say asking for a fresh release might be worth it but we could be waiting quite a long time & there could be other changes to account for in the package |
As discussed here: NixOS#374272 (comment) This pulls in element-hq/matrix-authentication-service@881c6df to update their Rego to be v1 ready. Signed-off-by: Charlie Egan <charlieegan3@users.noreply.github.com>
Ok, I think I've done the right thing in 35e6cb6 🙏 I've got to head but will check back in Monday if this is still needing attention. Thanks for the help here! |
As discussed here: NixOS#374272 (comment) This pulls in element-hq/matrix-authentication-service@881c6df to update their Rego to be v1 ready. Signed-off-by: Charlie Egan <charlieegan3@users.noreply.github.com>
8c6dee0
to
35e6cb6
Compare
Hope this is the correct process, we released the new version of OPA at the end of last year and the bot doesn't seem to have picked it up - perhaps because it's a major version?
The release notes are here: https://github.com/open-policy-agent/opa/releases/tag/v1.0.0, this release's main changes are:
v1
to allow v0 SDK use to not be distrupted. This requires a minor change in the package.nix file here to remove the same test in a new location.Upgrade process is outlined here: https://www.openpolicyagent.org/docs/latest/v0-upgrade/
V0 compatible functionality outlined here: https://www.openpolicyagent.org/docs/latest/v0-compatibility/
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.