Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tinycc: 0.9.27-unstable-2022-07-15 -> 0.9.27-unstable-2025-01-06 #374684

Merged
merged 3 commits into from
Jan 19, 2025

Conversation

onemoresuza
Copy link
Contributor

Fix checkPhase by making it instalCheckPhase, since tcc depends on
libtcc1.a, which is build together with it, for its tests.

Create dev, doc and lib outpus. Now the binaries, i. e., tcc and the
cross compilers are what the user gets with tinycc.out.

Make the recipe compliant with nixpkgs-hammer.

Enable parallel building.

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review


x86_64-linux

✅ 8 packages built:
  • kak-tree-sitter
  • nrpl
  • tinycc
  • tinycc.dev
  • tinycc.doc
  • tinycc.info
  • tinycc.lib
  • tinycc.man

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@AndersonTorres
Copy link
Member

  1. Please remove myself from maintainers. I will not have time to deal with this package anymore.
  2. Besides, LGTM.

@lucasew
Copy link
Contributor

lucasew commented Jan 19, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 374684


x86_64-linux

⏩ 1 package blacklisted:
  • tests.nixos-functions.nixos-test
✅ 9 packages built:
  • kak-tree-sitter
  • nixpkgs-manual
  • nrpl
  • tinycc
  • tinycc.dev
  • tinycc.doc
  • tinycc.info
  • tinycc.lib
  • tinycc.man

Fix checkPhase by making it instalCheckPhase, since tcc depends on
libtcc1.a, which is build together with it, for its tests.

Create dev, doc and lib outpus. Now the binaries, i. e., tcc and the
cross compilers are what the user gets with tinycc.out.

Make the recipe compliant with nixpkgs-hammer.

Enable parallel building.
@onemoresuza
Copy link
Contributor Author

  1. Please remove myself from maintainers. I will not have time to deal with this package anymore.

    1. Besides, LGTM.

Added a commit removing you as a maintainer.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/2200

@7c6f434c 7c6f434c merged commit 133940f into NixOS:master Jan 19, 2025
26 of 28 checks passed
@onemoresuza onemoresuza deleted the tinycc-update branch January 19, 2025 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants