Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shader-slang: 2025.3 -> 2025.3.1 #376342

Merged
merged 1 commit into from
Jan 24, 2025
Merged

Conversation

niklaskorz
Copy link
Contributor

@niklaskorz niklaskorz commented Jan 24, 2025

Changelog: https://github.com/shader-slang/slang/releases/tag/v2025.3.1

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@niklaskorz
Copy link
Contributor Author

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 376342


x86_64-linux

✅ 4 packages built:
  • shader-slang
  • shader-slang.debug
  • shader-slang.dev
  • shader-slang.doc

@niklaskorz niklaskorz added the 11.by: package-maintainer This PR was created by the maintainer of the package it changes label Jan 24, 2025
@niklaskorz
Copy link
Contributor Author

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 376342


aarch64-linux

✅ 4 packages built:
  • shader-slang
  • shader-slang.debug
  • shader-slang.dev
  • shader-slang.doc

x86_64-darwin

✅ 3 packages built:
  • shader-slang
  • shader-slang.dev
  • shader-slang.doc

aarch64-darwin

✅ 3 packages built:
  • shader-slang
  • shader-slang.dev
  • shader-slang.doc

Copy link
Contributor

@nbraud nbraud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, provided nixpkgs-review passes

@nbraud
Copy link
Contributor

nbraud commented Jan 24, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 376342


aarch64-darwin

✅ 3 packages built:
  • shader-slang
  • shader-slang.dev
  • shader-slang.doc

@nbraud
Copy link
Contributor

nbraud commented Jan 24, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 376342


x86_64-linux

✅ 4 packages built:
  • shader-slang
  • shader-slang.debug
  • shader-slang.dev
  • shader-slang.doc

@nbraud nbraud added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Jan 24, 2025
@nbraud nbraud merged commit 64497b0 into NixOS:master Jan 24, 2025
66 of 69 checks passed
fxzzi pushed a commit to fxzzi/nixpkgs that referenced this pull request Jan 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants