Skip to content

vimPlugins.llama-vim: init at 2025-01-24 #376352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 24, 2025
Merged

vimPlugins.llama-vim: init at 2025-01-24 #376352

merged 2 commits into from
Jan 24, 2025

Conversation

charlieegan3
Copy link
Contributor

@charlieegan3 charlieegan3 commented Jan 24, 2025 •
edited
Loading

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@charlieegan3
Copy link
Contributor Author

I'm trying to follow the guide here and unsure why the generated.nix file has not been updated by running:

nix-shell -p vimPluginsUpdater --run 'vim-plugins-updater add "ggml-org/llama.vim"'

@GaetanLepage
Copy link
Contributor

I'm trying to follow the guide here and unsure why the generated.nix file has not been updated by running:

nix-shell -p vimPluginsUpdater --run 'vim-plugins-updater add "ggml-org/llama.vim"'

Maybe you are on an older nix channel.
Try nix run .#vimPluginsUpdater -- --add ....

@charlieegan3
Copy link
Contributor Author

Thanks, that did the the trick! nix run .#vimPluginsUpdater -- add "ggml-org/llama.vim"

@charlieegan3
Copy link
Contributor Author

nix build .#vimPlugins.llama-vim / nix-build -A vimPlugins.llama-vim complete ok for me on aarch64-darwin so I have ticked that box - hope that's ok.

GaetanLepage
GaetanLepage approved these changes Jan 24, 2025
View reviewed changes
Copy link
Contributor

@GaetanLepage GaetanLepage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@charlieegan3
Copy link
Contributor Author

Thanks Gaétan!

@GaetanLepage
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 376352

x86_64-linux

✅ 2 packages built:
  • vimPlugins.llama-vim
  • vimPluginsUpdater

aarch64-linux

✅ 2 packages built:
  • vimPlugins.llama-vim
  • vimPluginsUpdater

x86_64-darwin

✅ 2 packages built:
  • vimPlugins.llama-vim
  • vimPluginsUpdater

aarch64-darwin

✅ 2 packages built:
  • vimPlugins.llama-vim
  • vimPluginsUpdater

@GaetanLepage GaetanLepage merged commit 7049906 into NixOS:master Jan 24, 2025
24 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GaetanLepage GaetanLepage GaetanLepage approved these changes

@mrcjkb mrcjkb Awaiting requested review from mrcjkb

@rvolosatovs rvolosatovs Awaiting requested review from rvolosatovs

@PerchunPak PerchunPak Awaiting requested review from PerchunPak

@figsoda figsoda Awaiting requested review from figsoda

@khaneliman khaneliman Awaiting requested review from khaneliman

@manveru manveru Awaiting requested review from manveru

Assignees
No one assigned
Labels
6.topic: vim 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@charlieegan3 @GaetanLepage