Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ocamlPackages.cpdf: 2.7.1 → 2.8 #376363

Merged
merged 1 commit into from
Jan 24, 2025
Merged

ocamlPackages.cpdf: 2.7.1 → 2.8 #376363

merged 1 commit into from
Jan 24, 2025

Conversation

vbgl
Copy link
Contributor

@vbgl vbgl commented Jan 24, 2025

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@momeemt
Copy link
Member

momeemt commented Jan 24, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 376363


aarch64-darwin

✅ 1 package built:
  • satysfi

Copy link
Member

@momeemt momeemt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nbraud

This comment was marked as outdated.

@nbraud
Copy link
Contributor

nbraud commented Jan 24, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 376363


x86_64-linux

✅ 1 package built:
  • satysfi

@nbraud
Copy link
Contributor

nbraud commented Jan 24, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 376363


aarch64-darwin

✅ 1 package built:
  • satysfi

Copy link
Contributor

@nbraud nbraud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good!

@nbraud nbraud merged commit bafca6c into NixOS:master Jan 24, 2025
24 of 27 checks passed
@vbgl vbgl deleted the ocaml-camlpdf-2.8 branch January 24, 2025 11:58
fxzzi pushed a commit to fxzzi/nixpkgs that referenced this pull request Jan 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants