-
-
Notifications
You must be signed in to change notification settings - Fork 15.4k
nixos/kmscon: Fix session & gpu clashing #391574
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
As per fbcon fashion, there's rendering issues. I guess the PR will get much more complicated if this doesn't turn out to be a fluke. |
Ok, this might just be a greetd issue I'm having. Either way, it would be great if someone would test this under "normal" circumstances |
Enabled with GNOME and it seems to work like it used to. Didn’t test extensively, but at least GDM is able to start now. |
Yeah, I suspect the current rev we're in actually works as intended and we actually have to disable DRM specifically. There also is the option to patch kmscon to allow it to free the gpu on demand. However, we would also have to modify every single derivation that starts a graphical session or needs /dev/dri/cardX so it also tells kmscon to free the GPU, just so we use DRM for kmscon (and I don't know any benefits of using DRM over fbcon for kmscon) |
how do i undo this git has played me |
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/5352 |
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/5372 |
I couldn't use kmscon for a while because it broke SDDM and with this patch I found 2 issues immediately:
|
Maybe that's why specifying a seat is necessary? Try specifying a seat as an extra argument. There is a bandaid fix so kmscon can free the GPU but that would require wrapping every single binary that will have to access the GPU (wrap Plasma, GNOME, Sway, Hyprland, etc.). Even then performance isn't guaranteed. |
Yeah, we cannot wrap every other binary. There must be another way. |
Things done
Adjusted the systemd unit for kmscon to fix #385497
This however will completely disable DRM for kmscon and now seats will be unspecified.
If someone absolutely requires DRM for kmscon, let me know.
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.