Skip to content

Conversation

@wrvsrx
Copy link
Contributor

@wrvsrx wrvsrx commented Aug 26, 2025

Currently anki fails to build due to rust 1.89. This PR fix it.

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 6.topic: games Gaming on NixOS labels Aug 26, 2025
@nix-owners nix-owners bot requested review from JuneStepp, euank and oxij August 26, 2025 08:03
@eljamm
Copy link
Contributor

eljamm commented Aug 26, 2025

Thanks for the fix, but I think that we should close this in favor of #425219, which also includes it in addition to the version bump.

@euank
Copy link
Member

euank commented Aug 27, 2025

Thanks for noticing the issue and fixing the build @wrvsrx, appreciated!

I'm okay merging this first if we think #425219 will take much longer to merge (though we could cherry-pick the patch file from #425219 to reduce the chance of merge-conflict).

If #425219 is able to land soon, I think it's fine to wait on that and avoid one merge conflict.

@wrvsrx
Copy link
Contributor Author

wrvsrx commented Aug 27, 2025

Close it in favor of #425219

@wrvsrx wrvsrx closed this Aug 27, 2025
@wrvsrx wrvsrx deleted the fix-anki-build branch September 6, 2025 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: games Gaming on NixOS 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants