Skip to content

Conversation

@nim65s
Copy link
Contributor

@nim65s nim65s commented Aug 27, 2025

webengine is optional:

extensions/PythonQt_QtAll/PythonQt_QtAll.pro
24:  qtHaveModule(webenginewidgets):CONFIG += PythonQtWebEngineWidgets

So disable it by default to fix build
following #435067

edit: while here, let's get a Qt6 version, where qtwebengine is still maintained.

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. labels Aug 27, 2025
@nim65s
Copy link
Contributor Author

nim65s commented Aug 27, 2025

While here, add Qt6 support, where qtwebengine is available

@nixpkgs-ci nixpkgs-ci bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Aug 27, 2025
@ofborg ofborg bot added the ofborg-internal-error Ofborg encountered an error label Aug 27, 2025
@nim65s nim65s force-pushed the pythonqt branch 2 times, most recently from 92bbb2f to 095c6f8 Compare August 27, 2025 21:12
@ofborg ofborg bot removed the ofborg-internal-error Ofborg encountered an error label Aug 27, 2025
@nim65s nim65s changed the title python-qt: disable vulnerable qtwebengine by default python-qt: disable vulnerable qtwebengine by default, add Qt6 support Aug 28, 2025
@nim65s
Copy link
Contributor Author

nim65s commented Aug 28, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 437521
Commit: d720239cc3c630e3c1fbcae2df046b551d845f5f


x86_64-linux

⏩ 1 package marked as broken and skipped:
  • csound-qt
✅ 18 packages built:
  • gepetto-viewer (python313Packages.gepetto-viewer)
  • gepetto-viewer-corba (python313Packages.gepetto-viewer-corba)
  • gepetto-viewer-corba.doc (python313Packages.gepetto-viewer-corba.doc)
  • gepetto-viewer.bin (python313Packages.gepetto-viewer.bin)
  • gepetto-viewer.dev (python313Packages.gepetto-viewer.dev)
  • gepetto-viewer.doc (python313Packages.gepetto-viewer.doc)
  • kdePackages.python-qt (python313Packages.python-qt-qt6, qt6Packages.python-qt)
  • python-qt (libsForQt5.python-qt, python313Packages.python-qt)
  • python312Packages.gepetto-gui
  • python312Packages.gepetto-viewer
  • python312Packages.gepetto-viewer-corba
  • python312Packages.gepetto-viewer-corba.doc
  • python312Packages.gepetto-viewer.bin
  • python312Packages.gepetto-viewer.dev
  • python312Packages.gepetto-viewer.doc
  • python312Packages.python-qt
  • python312Packages.python-qt-qt6
  • python313Packages.gepetto-gui

aarch64-darwin

✅ 16 packages built:
  • gepetto-viewer (python313Packages.gepetto-viewer)
  • gepetto-viewer-corba (python313Packages.gepetto-viewer-corba)
  • gepetto-viewer-corba.doc (python313Packages.gepetto-viewer-corba.doc)
  • gepetto-viewer.bin (python313Packages.gepetto-viewer.bin)
  • gepetto-viewer.dev (python313Packages.gepetto-viewer.dev)
  • gepetto-viewer.doc (python313Packages.gepetto-viewer.doc)
  • python-qt (libsForQt5.python-qt, python313Packages.python-qt)
  • python312Packages.gepetto-gui
  • python312Packages.gepetto-viewer
  • python312Packages.gepetto-viewer-corba
  • python312Packages.gepetto-viewer-corba.doc
  • python312Packages.gepetto-viewer.bin
  • python312Packages.gepetto-viewer.dev
  • python312Packages.gepetto-viewer.doc
  • python312Packages.python-qt
  • python313Packages.gepetto-gui

@nim65s nim65s marked this pull request as ready for review August 28, 2025 08:41
@nix-owners nix-owners bot requested review from hlolli and natsukium August 28, 2025 08:43
@nim65s
Copy link
Contributor Author

nim65s commented Aug 28, 2025

cc @hlolli @LordGrimmauld

@LordGrimmauld
Copy link
Contributor

I wonder if we should default to the qt6 version instead...

@LordGrimmauld
Copy link
Contributor

Ah wait its broken on darwin on qt6, fair enough to keep it on qt5 for now then. I don't particularly like staying on qt5, but so be it.

@nim65s
Copy link
Contributor Author

nim65s commented Aug 28, 2025

I am considering to do this in several steps:

  1. add Qt6 opt-in here
  2. add Qt6 opt-in in all its reverse dependencies (eg. osgqt: add Qt6 support #437594, which is a dependency of one reverse-dependency…), or document when it is not feasible
  3. switch default to Qt6
  4. drop Qt5 where possible

@nim65s nim65s mentioned this pull request Sep 1, 2025
13 tasks
@nim65s nim65s changed the title python-qt: disable vulnerable qtwebengine by default, add Qt6 support python-qt: disable vulnerable Qt5 webengine by default, add Qt6 support Sep 4, 2025
@nim65s nim65s changed the title python-qt: disable vulnerable Qt5 webengine by default, add Qt6 support python-qt: disable vulnerable Qt5 webengine by default, add Qt6 support, clean, adopt Sep 8, 2025
Copy link
Contributor

@SigmaSquadron SigmaSquadron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commits and diff looks good. Also builds properly on Linux.

@nixpkgs-ci nixpkgs-ci bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Oct 8, 2025
@nim65s
Copy link
Contributor Author

nim65s commented Nov 28, 2025

rebased for Qt6.10.1

@nim65s nim65s marked this pull request as draft November 28, 2025 11:03
@nim65s nim65s force-pushed the pythonqt branch 6 times, most recently from 1ca6578 to c27fe4f Compare November 30, 2025 10:36
@nim65s nim65s marked this pull request as ready for review November 30, 2025 11:31
webengine is optional:

```
extensions/PythonQt_QtAll/PythonQt_QtAll.pro
24:  qtHaveModule(webenginewidgets):CONFIG += PythonQtWebEngineWidgets
```

So disable it by default to fix build
following NixOS#435067
It now need way more fixes than what should be done in this python-qt PR
@nim65s
Copy link
Contributor Author

nim65s commented Dec 11, 2025

rebased after #443046

@nim65s
Copy link
Contributor Author

nim65s commented Dec 18, 2025

nixpkgs-review result for #437521

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 437521
Commit: 86fa124b5b7051e1e8cd274d17f47479c2344411 (subsequent changes)
Merge: bd7bb4bf56e187bc83348e6117af5ee673438135

Logs: https://github.com/nim65s/nixpkgs-review-gha/actions/runs/20127267590


x86_64-linux

⏩ 1 package marked as broken and skipped:
  • csound-qt
✅ 4 packages built:
  • kdePackages.python-qt (python313Packages.python-qt-qt6, qt6Packages.python-qt)
  • python-qt (libsForQt5.python-qt, python313Packages.python-qt)
  • python312Packages.python-qt
  • python312Packages.python-qt-qt6

aarch64-linux

⏩ 1 package marked as broken and skipped:
  • csound-qt
✅ 4 packages built:
  • kdePackages.python-qt (python313Packages.python-qt-qt6, qt6Packages.python-qt)
  • python-qt (libsForQt5.python-qt, python313Packages.python-qt)
  • python312Packages.python-qt
  • python312Packages.python-qt-qt6

x86_64-darwin (sandbox = relaxed)

✅ 2 packages built:
  • python-qt (libsForQt5.python-qt, python313Packages.python-qt)
  • python312Packages.python-qt

aarch64-darwin (sandbox = relaxed)

✅ 2 packages built:
  • python-qt (libsForQt5.python-qt, python313Packages.python-qt)
  • python312Packages.python-qt

@nim65s nim65s marked this pull request as draft January 13, 2026 13:46
@nim65s
Copy link
Contributor Author

nim65s commented Jan 13, 2026

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 437521
Commit: e7e2d1745cb9ac339b3de67f2b28787297fbef29 (subsequent changes)
Merge: e87f1ad973fd984aed24dcf4e8cc13cf583c1915

Logs: https://github.com/nim65s/nixpkgs-review-gha/actions/runs/20959054595


x86_64-linux

⏩ 1 package marked as broken and skipped:
  • csound-qt
✅ 4 packages built:
  • kdePackages.python-qt (python313Packages.python-qt-qt6, qt6Packages.python-qt)
  • python-qt (libsForQt5.python-qt, python313Packages.python-qt)
  • python314Packages.python-qt
  • python314Packages.python-qt-qt6

aarch64-linux

⏩ 1 package marked as broken and skipped:
  • csound-qt
✅ 4 packages built:
  • kdePackages.python-qt (python313Packages.python-qt-qt6, qt6Packages.python-qt)
  • python-qt (libsForQt5.python-qt, python313Packages.python-qt)
  • python314Packages.python-qt
  • python314Packages.python-qt-qt6

x86_64-darwin (sandbox = relaxed)

❌ 2 packages failed to build:
  • kdePackages.python-qt (python313Packages.python-qt-qt6, qt6Packages.python-qt)
  • python314Packages.python-qt-qt6
✅ 2 packages built:
  • python-qt (libsForQt5.python-qt, python313Packages.python-qt)
  • python314Packages.python-qt

Error logs: `x86_64-darwin`
kdePackages.python-qt
ld: warning: dylib (/nix/store/nmyqs1v31s1274ry57q4l31sq64qdqy1-qtdeclarative-6.10.1/lib/QtQml.framework/QtQml) was built for newer macOS version (14.0) than being linked (13.0)
ld: warning: dylib (/nix/store/9fppq8gfy7j8g7k62my3zdpgiwxr705p-qtpositioning-6.10.1/lib/QtPositioning.framework/QtPositioning) was built for newer macOS version (14.0) than being linked (13.0)
ld: warning: dylib (/nix/store/p4lhvmp0qc7pwd4ngq033m1kshhqgxwy-cups-2.4.16-lib/lib/libcups.dylib) was built for newer macOS version (14.0) than being linked (13.0)
ld: warning: dylib (/nix/store/sbp7sp9a43cvdlc98h0997flifb9gfn7-gettext-0.25.1/lib/libintl.dylib) was built for newer macOS version (14.0) than being linked (13.0)
Undefined symbols for architecture x86_64:
  "PythonQt_init_QtQml(_object*)", referenced from:
      PythonQt_QtAll::init() in PythonQt_QtAll.o
  "PythonQt_init_QtSvg(_object*)", referenced from:
      PythonQt_QtAll::init() in PythonQt_QtAll.o
  "PythonQt_init_QtQuick(_object*)", referenced from:
      PythonQt_QtAll::init() in PythonQt_QtAll.o
  "PythonQt_init_QtUiTools(_object*)", referenced from:
      PythonQt_QtAll::init() in PythonQt_QtAll.o
ld: symbol(s) not found for architecture x86_64
clang++: error: linker command failed with exit code 1 (use -v to see invocation)
make[2]: *** [Makefile:460: ../../lib/libPythonQt_QtAll-Qt6-Python3.13.3.2.0.dylib] Error 1
make[2]: Leaving directory '/nix/build/nix-15391-2557389624/source/extensions/PythonQt_QtAll'
make[1]: *** [Makefile:54: sub-PythonQt_QtAll-make_first] Error 2
make[1]: Leaving directory '/nix/build/nix-15391-2557389624/source/extensions'
make: *** [Makefile:108: sub-extensions-make_first] Error 2
python314Packages.python-qt-qt6
ld: warning: dylib (/nix/store/nmyqs1v31s1274ry57q4l31sq64qdqy1-qtdeclarative-6.10.1/lib/QtQml.framework/QtQml) was built for newer macOS version (14.0) than being linked (13.0)
ld: warning: dylib (/nix/store/9fppq8gfy7j8g7k62my3zdpgiwxr705p-qtpositioning-6.10.1/lib/QtPositioning.framework/QtPositioning) was built for newer macOS version (14.0) than being linked (13.0)
ld: warning: dylib (/nix/store/p4lhvmp0qc7pwd4ngq033m1kshhqgxwy-cups-2.4.16-lib/lib/libcups.dylib) was built for newer macOS version (14.0) than being linked (13.0)
ld: warning: dylib (/nix/store/sbp7sp9a43cvdlc98h0997flifb9gfn7-gettext-0.25.1/lib/libintl.dylib) was built for newer macOS version (14.0) than being linked (13.0)
Undefined symbols for architecture x86_64:
  "PythonQt_init_QtQml(_object*)", referenced from:
      PythonQt_QtAll::init() in PythonQt_QtAll.o
  "PythonQt_init_QtSvg(_object*)", referenced from:
      PythonQt_QtAll::init() in PythonQt_QtAll.o
  "PythonQt_init_QtQuick(_object*)", referenced from:
      PythonQt_QtAll::init() in PythonQt_QtAll.o
  "PythonQt_init_QtUiTools(_object*)", referenced from:
      PythonQt_QtAll::init() in PythonQt_QtAll.o
ld: symbol(s) not found for architecture x86_64
clang++: error: linker command failed with exit code 1 (use -v to see invocation)
make[2]: *** [Makefile:460: ../../lib/libPythonQt_QtAll-Qt6-Python3.14.3.2.0.dylib] Error 1
make[2]: Leaving directory '/nix/build/nix-15391-2557389625/source/extensions/PythonQt_QtAll'
make[1]: *** [Makefile:54: sub-PythonQt_QtAll-make_first] Error 2
make[1]: Leaving directory '/nix/build/nix-15391-2557389625/source/extensions'
make: *** [Makefile:108: sub-extensions-make_first] Error 2

aarch64-darwin (sandbox = relaxed)

❌ 2 packages failed to build:
  • kdePackages.python-qt (python313Packages.python-qt-qt6, qt6Packages.python-qt)
  • python314Packages.python-qt-qt6
✅ 2 packages built:
  • python-qt (libsForQt5.python-qt, python313Packages.python-qt)
  • python314Packages.python-qt

Error logs: `aarch64-darwin`
kdePackages.python-qt
ld: warning: dylib (/nix/store/hpszjrsb87220nkp76drm56zs67icrmp-qtdeclarative-6.10.1/lib/QtQml.framework/QtQml) was built for newer macOS version (14.0) than being linked (13.0)
ld: warning: dylib (/nix/store/injw0wi1kk89pbrlyahnrjzj2sqj32jq-qtpositioning-6.10.1/lib/QtPositioning.framework/QtPositioning) was built for newer macOS version (14.0) than being linked (13.0)
ld: warning: dylib (/nix/store/snkk7052rxngiln2gmrjz3x8carcfvhi-cups-2.4.16-lib/lib/libcups.dylib) was built for newer macOS version (14.0) than being linked (13.0)
ld: warning: dylib (/nix/store/axw3iz1kfaq6nir6jj1vk5a0g1nfg0wk-gettext-0.25.1/lib/libintl.dylib) was built for newer macOS version (14.0) than being linked (13.0)
Undefined symbols for architecture arm64:
  "PythonQt_init_QtQml(_object*)", referenced from:
      PythonQt_QtAll::init() in PythonQt_QtAll.o
  "PythonQt_init_QtSvg(_object*)", referenced from:
      PythonQt_QtAll::init() in PythonQt_QtAll.o
  "PythonQt_init_QtQuick(_object*)", referenced from:
      PythonQt_QtAll::init() in PythonQt_QtAll.o
  "PythonQt_init_QtUiTools(_object*)", referenced from:
      PythonQt_QtAll::init() in PythonQt_QtAll.o
ld: symbol(s) not found for architecture arm64
clang++: error: linker command failed with exit code 1 (use -v to see invocation)
make[2]: *** [Makefile:460: ../../lib/libPythonQt_QtAll-Qt6-Python3.13.3.2.0.dylib] Error 1
make[2]: Leaving directory '/nix/build/nix-6435-1911157820/source/extensions/PythonQt_QtAll'
make[1]: *** [Makefile:54: sub-PythonQt_QtAll-make_first] Error 2
make[1]: Leaving directory '/nix/build/nix-6435-1911157820/source/extensions'
make: *** [Makefile:108: sub-extensions-make_first] Error 2
python314Packages.python-qt-qt6
ld: warning: dylib (/nix/store/hpszjrsb87220nkp76drm56zs67icrmp-qtdeclarative-6.10.1/lib/QtQml.framework/QtQml) was built for newer macOS version (14.0) than being linked (13.0)
ld: warning: dylib (/nix/store/injw0wi1kk89pbrlyahnrjzj2sqj32jq-qtpositioning-6.10.1/lib/QtPositioning.framework/QtPositioning) was built for newer macOS version (14.0) than being linked (13.0)
ld: warning: dylib (/nix/store/snkk7052rxngiln2gmrjz3x8carcfvhi-cups-2.4.16-lib/lib/libcups.dylib) was built for newer macOS version (14.0) than being linked (13.0)
ld: warning: dylib (/nix/store/axw3iz1kfaq6nir6jj1vk5a0g1nfg0wk-gettext-0.25.1/lib/libintl.dylib) was built for newer macOS version (14.0) than being linked (13.0)
Undefined symbols for architecture arm64:
  "PythonQt_init_QtQml(_object*)", referenced from:
      PythonQt_QtAll::init() in PythonQt_QtAll.o
  "PythonQt_init_QtSvg(_object*)", referenced from:
      PythonQt_QtAll::init() in PythonQt_QtAll.o
  "PythonQt_init_QtQuick(_object*)", referenced from:
      PythonQt_QtAll::init() in PythonQt_QtAll.o
  "PythonQt_init_QtUiTools(_object*)", referenced from:
      PythonQt_QtAll::init() in PythonQt_QtAll.o
ld: symbol(s) not found for architecture arm64
clang++: error: linker command failed with exit code 1 (use -v to see invocation)
make[2]: *** [Makefile:460: ../../lib/libPythonQt_QtAll-Qt6-Python3.14.3.2.0.dylib] Error 1
make[2]: Leaving directory '/nix/build/nix-6435-1911157822/source/extensions/PythonQt_QtAll'
make[1]: *** [Makefile:54: sub-PythonQt_QtAll-make_first] Error 2
make[1]: Leaving directory '/nix/build/nix-6435-1911157822/source/extensions'
make: *** [Makefile:108: sub-extensions-make_first] Error 2

@nim65s
Copy link
Contributor Author

nim65s commented Jan 13, 2026

Following decisions on "NixOS Security Discussions" on matrix, we'll drop instead

@nim65s nim65s closed this Jan 13, 2026
@nim65s
Copy link
Contributor Author

nim65s commented Jan 14, 2026

ref. #480008

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 12.approvals: 2 This PR was reviewed and approved by two persons.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants