anki: move python libraries into 'lib' output #438958
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nixpkgs-ci
bot
added
10.rebuild-linux: 1-10
eyJhb
reviewed
Aug 31, 2025
Member
eyJhb
left a comment
eyJhb
left a comment
There was a problem hiding this comment.
I've tested these changes, and they resolve the issues I had. Confirmed that Anki still works as well :)
I'm not that much into how $out vs. $lib, so I can't comment on that sadly. But I really appreciate the fast response ❤️
eljamm
approved these changes
Sep 9, 2025
Contributor
eljamm
left a comment
eljamm
left a comment
There was a problem hiding this comment.
Looks good aside from the small nit.
nixpkgs-ci
bot
added
the
12.approvals: 1
Fixes NixOS#438598 Anki's packaging got reworked in NixOS#425219, and one of the changes was to effectively 'pip install' the anki wheel into $out directly. This resulted in an output structure of '$out/bin' and '$out/lib', with python files in 'lib'. Per NixOS#438598, this can cause conflicts. Let's split anki into `anki.out` and `anki.lib`, requiring a user to specifically include `anki.lib` in their environment in order to hit the python conflicts described there. This seems like the easiest solution, though I'm of course open to any better alternatives.
euank
force-pushed
the
anki-split-lib
branch
from
8478a82 to
f955f2c
Compare
eljamm
approved these changes
Sep 10, 2025
Contributor
eljamm
left a comment
eljamm
left a comment
There was a problem hiding this comment.
nixpkgs-review result
Generated using nixpkgs-review-gha
Command: nixpkgs-review pr 438958
Commit: f955f2ce5e400bcccfc506c0bc7e6662567dd4f1 (subsequent changes)
Merge: 99cf65bb19aa9eb018070168f23e190df2d138e3
Logs: https://github.com/eljamm/nixpkgs-review-gha/actions/runs/17626292759
x86_64-linux
✅ 8 packages built:
- anki
- anki.doc
- anki.lib
- anki.man
- ki
- ki.dist
- mnemosyne
- mnemosyne.dist
aarch64-linux
✅ 8 packages built:
- anki
- anki.doc
- anki.lib
- anki.man
- ki
- ki.dist
- mnemosyne
- mnemosyne.dist
x86_64-darwin
✅ No rebuilds
aarch64-darwin
✅ No rebuilds
qweered
approved these changes
Sep 11, 2025
nixpkgs-ci
bot
added
12.approvals: 2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #438598
Anki's packaging got reworked in
#425219, and one of the changes was to effectively 'pip install' the wheels for anki and its dependencies into $out directly.
This resulted in an output structure of '$out/bin' and '$out/lib', with python files in 'lib'.
Per #438598, this can cause conflicts.
Let's split anki into
anki.outandanki.lib, requiring a user to specifically includeanki.libin their environment in order to hit the python conflicts described there.This seems like the easiest solution, though I'm of course open to any better alternatives.
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.