Skip to content

mew: init at 1.0-unstable-2025-06-20 #463370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
GaetanLepage merged 1 commit into from
Nov 26, 2025
Merged

mew: init at 1.0-unstable-2025-06-20 #463370

GaetanLepage merged 1 commit into from
Nov 26, 2025

Conversation

@Notarin
Copy link
Contributor

@Notarin Notarin commented Nov 20, 2025

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

adisbladis
adisbladis requested changes Nov 20, 2025
View reviewed changes
@Notarin Notarin marked this pull request as draft November 20, 2025 04:36
@Notarin Notarin force-pushed the mew branch 2 times, most recently from db9e694 to 49c7402 Compare November 20, 2025 04:40
@Notarin Notarin marked this pull request as ready for review November 20, 2025 04:40
@Notarin Notarin requested a review from adisbladis November 20, 2025 04:41
@Notarin Notarin marked this pull request as draft November 20, 2025 04:43
@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 1 This PR was reviewed and approved by one person. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Nov 20, 2025
@Notarin Notarin marked this pull request as ready for review November 20, 2025 04:54
@Notarin
Copy link
Contributor Author

Notarin commented Nov 20, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 463370
Commit: a30cbfdcdc8ec2a553839c6f73e3e05d027cde8f

x86_64-linux

✅ 1 package built:
  • mew

player131007
player131007 reviewed Nov 20, 2025
View reviewed changes
@Notarin Notarin requested a review from player131007 November 20, 2025 05:25
@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 2 This PR was reviewed and approved by two persons. and removed 12.approvals: 1 This PR was reviewed and approved by one person. labels Nov 20, 2025
GaetanLepage
GaetanLepage reviewed Nov 26, 2025
View reviewed changes
@Notarin Notarin force-pushed the mew branch 3 times, most recently from d32afd0 to 91de884 Compare November 26, 2025 10:03
@GaetanLepage
Copy link
Contributor

GaetanLepage commented Nov 26, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 463370
Commit: 91de884c2a150976ebe872880d2f8aa378ef0f68

x86_64-linux

✅ 1 package built:
  • mew

aarch64-linux

✅ 1 package built:
  • mew

GaetanLepage
GaetanLepage approved these changes Nov 26, 2025
View reviewed changes
Copy link
Contributor

@GaetanLepage GaetanLepage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally. Thanks

@GaetanLepage GaetanLepage added this pull request to the merge queue Nov 26, 2025
@Notarin
Copy link
Contributor Author

Notarin commented Nov 26, 2025

Thank you for working with me!

@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 3+ This PR was reviewed and approved by three or more persons. and removed 12.approvals: 2 This PR was reviewed and approved by two persons. labels Nov 26, 2025
Merged via the queue into NixOS:master with commit 1ab959a Nov 26, 2025
26 checks passed
@Notarin Notarin deleted the mew branch November 26, 2025 10:29
SuperSandro2000
SuperSandro2000 reviewed Nov 27, 2025
View reviewed changes
pkgs/by-name/me/mew/package.nix
Comment on lines +38 to +39
wayland-protocols
wayland-scanner
Copy link
Member

@SuperSandro2000 SuperSandro2000 Nov 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think scanner went into nativeBuildInputs for cross

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

@adisbladis adisbladis adisbladis approved these changes

@GaetanLepage GaetanLepage GaetanLepage approved these changes

+1 more reviewer

@player131007 player131007 player131007 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 3+ This PR was reviewed and approved by three or more persons.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Notarin @GaetanLepage @adisbladis @SuperSandro2000 @player131007