Skip to content

Conversation

@jennydaman
Copy link
Contributor

The current version of redlib in nixpkgs does not work. This PR restores functionality.

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot requested review from Guanran928 and bpeetz December 17, 2025 06:48
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Dec 17, 2025
@Guanran928
Copy link
Contributor

Sorry, I don't use this package anymore, could you remove me from meta.maintainers?

Copy link
Contributor

@Guanran928 Guanran928 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diff looks good.

@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels Dec 17, 2025
@Jeidnx
Copy link

Jeidnx commented Dec 17, 2025

built and tested on x86_64-linux.
Works as expected

@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 2 This PR was reviewed and approved by two persons. 2.status: merge-bot eligible This PR can be merged by commenting "@NixOS/nixpkgs-merge-bot merge". and removed 12.approvals: 1 This PR was reviewed and approved by one person. labels Dec 17, 2025
Copy link
Contributor

@bpeetz bpeetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diff looks good.

@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 3+ This PR was reviewed and approved by three or more persons. and removed 12.approvals: 2 This PR was reviewed and approved by two persons. labels Dec 17, 2025
@bpeetz
Copy link
Contributor

bpeetz commented Dec 18, 2025

@NixOS/nixpkgs-merge-bot merge

@nixpkgs-ci nixpkgs-ci bot added this pull request to the merge queue Dec 18, 2025
@nixpkgs-ci
Copy link
Contributor

nixpkgs-ci bot commented Dec 18, 2025

@bpeetz wants to merge this PR.

Requirements to merge this PR with @NixOS/nixpkgs-merge-bot merge:

  • ✅ PR targets a development branch.
  • ✅ PR touches only files of packages in pkgs/by-name/.
  • ✅ PR is at least one of:
    • ✅ Approved by a committer.
    • ⬜ Backported via label.
    • ⬜ Opened by a committer.
    • ⬜ Opened by r-ryantm.
  • ✅ bpeetz is a member of @NixOS/nixpkgs-maintainers.
  • ✅ bpeetz is a maintainer of all touched packages.

✔️ Enabled Auto Merge (#306934)

Tip

Sometimes GitHub gets stuck after enabling Auto Merge. In this case, leaving another approval should trigger the merge.

Merged via the queue into NixOS:master with commit 9d0bb94 Dec 18, 2025
39 of 41 checks passed
@jennydaman jennydaman deleted the redlib-dec2025 branch December 18, 2025 22:28
@jennydaman
Copy link
Contributor Author

@Guanran928 I would be happy to replace you in meta.maintainers if you could provide me with some guidance on how to get started. I am not yet a nixpkgs maintainer.

@Guanran928
Copy link
Contributor

@Guanran928 I would be happy to replace you in meta.maintainers if you could provide me with some guidance on how to get started. I am not yet a nixpkgs maintainer.

It’s actually quite simple! You can add yourself to ./maintainers/maintainer-list.nix (and to meta.maintainers in this package), then open a PR. Once the PR is merged, you’ll be automatically invited to the NixOS GitHub organization.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2.status: merge-bot eligible This PR can be merged by commenting "@NixOS/nixpkgs-merge-bot merge". 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 3+ This PR was reviewed and approved by three or more persons. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants