Skip to content

pi-coding-agent: switch to npx tsgo to avoid version mismatch#505279

Open
kachick wants to merge 1 commit intoNixOS:masterfrom
kachick:pi-coding-agent-switch-to-npx-tsgo
Open

pi-coding-agent: switch to npx tsgo to avoid version mismatch#505279
kachick wants to merge 1 commit intoNixOS:masterfrom
kachick:pi-coding-agent-switch-to-npx-tsgo

Conversation

@kachick
Copy link
Copy Markdown
Member

@kachick kachick commented Mar 31, 2026

This PR prevents build errors when updating the typescript-go package.
It addresses the issue reported in #501241 (comment).

Recent typescript-go updates introduce stricter regex validation that triggers TS1501 on older ES targets.
This change switches to npx tsgo to maintain compatibility with the package's existing tsconfig.

Refs:

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

cc: @Munksgaard @mbwilding

Recent typescript-go updates introduce stricter regex validation
that triggers TS1501 on older ES targets.
This change switches to npx tsgo to maintain compatibility
with the package's existing tsconfig.

Refs:
- https://github.com/badlogic/pi-mono/blob/v0.62.0/package.json#L38
- https://github.com/badlogic/pi-mono/blob/v0.62.0/packages/tui/src/utils.ts#L32-L34
- microsoft/typescript-go@880a9e9
@mbwilding
Copy link
Copy Markdown

Will test it out in a few hours.

@nixpkgs-ci nixpkgs-ci bot requested a review from Munksgaard March 31, 2026 11:54
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Mar 31, 2026
@kachick
Copy link
Copy Markdown
Member Author

kachick commented Mar 31, 2026

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 505279
Commit: da5f13b42a5c43cc927242c72ea650b147951efd


x86_64-linux

✅ 1 package built:
  • pi-coding-agent

aarch64-linux

✅ 1 package built:
  • pi-coding-agent

x86_64-darwin

✅ 1 package built:
  • pi-coding-agent

aarch64-darwin

✅ 1 package built:
  • pi-coding-agent

@mbwilding
Copy link
Copy Markdown

Package built and worked as expected.

@nixpkgs-ci nixpkgs-ci bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Mar 31, 2026
@Munksgaard
Copy link
Copy Markdown
Contributor

Built and working as expected here as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants