adoptopenjdk-bin: add OpenJDK 13#71016
Closed
lopsided98 wants to merge 2 commits intoNixOS:masterfrom
Closed
Conversation
10 tasks
80918bc to
d9d5b73
Compare
taku0
approved these changes
Oct 13, 2019
Contributor
taku0
left a comment
There was a problem hiding this comment.
LGTM. It works on nixOS and macOS Catalina (10.15).
d9d5b73 to
984f513
Compare
Contributor
|
LGTM again. It works on nixOS and macOS Catalina (10.15). Not tested on ARM processors. |
984f513 to
48071ff
Compare
Contributor
Author
|
Included in #70983 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Adds AdoptOpenJDK builds of OpenJDK 13, as well as updating some of the other builds. AdoptOpenJDK provides 32-bit ARM builds of OpenJDK 8 now, so the update script added them as well. I tested that JDK 13 build was able to start JMeter on
x86_64-linux, and that thearmv7l-linuxJDK 8 package builds, but did not do any runtime testing on that platform.I do not think the 32-bit ARM JDK 8 build will be able to bootstrap our
openjdk8package (but I haven't tried), because I believe OpenJDK 8 requires some patches to build on ARM.The JDK 13 builds should be able to bootstrap our source build of OpenJDK 13 in #70983.
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)Notify maintainers
cc @jerith666
cc @taku0