Skip to content

Conversation

@nasaul
Copy link

@nasaul nasaul commented Dec 1, 2025

  • Replaces double backlash with only one

@nasaul nasaul marked this pull request as ready for review December 1, 2025 22:22
@nasaul nasaul requested a review from deven367 December 1, 2025 22:22
Copy link
Contributor

@deven367 deven367 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @nasaul, can we also update the failing test here itself? And, since the inheritence logic was updated as well, can we include tests for classes BottomUp, TopDown in hierarchicalforecast?

@nasaul nasaul requested a review from deven367 December 3, 2025 19:19
@nasaul
Copy link
Author

nasaul commented Dec 3, 2025

Already updated the testing @deven367

The corresponding hierarchical "projection" matrix is defined as:
$$
\\\\mathbf{P}_{\\\\text{BU}} = \\[\\\\mathbf{0}_{\\\\mathrm{[b],[a]}};|;\\\\mathbf{I}\\_{\\\\mathrm{[b][b]}}\\]
\\mathbf{P}_{\\text{BU}} = \[\\mathbf{0}_{\\mathrm{[b],[a]}};|;\\mathbf{I}\_{\\mathrm{[b][b]}}\]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a bit strange. This will not render correctly! For pure latex blocks, we need \ instead of \\, any ideas on how to handle it? was it handled correctly before?

Copy link
Author

@nasaul nasaul Dec 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this will not render correctly. The solution is to use the ```math code block syntax as in the alternative solution in here. However I think that first, we need to update the documentation of hierarchicalforecast and then we update the test suite of `mkdocstrings-parser`

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants