Skip to content

Conversation

@PierreDemailly
Copy link
Member

No description provided.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR migrates the workspaces server and cache modules from JavaScript to TypeScript, adding comprehensive type annotations and updating build/test configurations.

  • Introduces new tsconfig files and updates package.json scripts for TypeScript builds.
  • Adds explicit TypeScript annotations across endpoints, middlewares, web socket commands, and tests.
  • Enhances type safety by replacing implicit types and adding non-null assertions where needed.

Reviewed Changes

Copilot reviewed 38 out of 41 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
workspaces/server/tsconfig.json New TypeScript configuration for the server module
workspaces/server/test/* Test files updated with explicit type annotations
workspaces/server/src/* Source files updated to include TypeScript types and non-null assertions
workspaces/cache/* Cache module modified to use TypeScript and improved type safety
package.json, tsconfig.base.json, eslint.config.mjs Build/test and linter configurations updated for TypeScript
Comments suppressed due to low confidence (1)

workspaces/server/src/websocket/index.ts:29

  • [nitpick] Consider renaming 'WebSocketServerInstanciator' to 'WebSocketServerInstantiator' to use conventional spelling.
export class WebSocketServerInstanciator {

@PierreDemailly PierreDemailly merged commit 23f2183 into master Jun 29, 2025
13 checks passed
@PierreDemailly PierreDemailly deleted the typescript branch June 29, 2025 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants