feat: support repository.homepage #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Theses changes add support for
repository.homepage.When using
await scorecard.result("@topcli/prompts", { resolveOnVersionControl: false });it fails because the package does not have the repository field set in package.json. However, the homepage is set.Note: this is also what we do in scanner so we are ISO: https://github.com/NodeSecure/scanner/blob/master/src/utils/getLinks.js#L34
Note: I'll add (in a next PR) a
npmVersionoption that allow to fetch a specific package version instead of the latest-release, it will allow to functional test theses changes with the@topcli/promptspackage, i'll lock the version to 1.9.0 then if we add the repository field the test does not break.Draft until NodeSecure/npm-registry-sdk#125