Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upgrade to polkadot 1.5.0 #816

Merged
merged 21 commits into from
Feb 9, 2024
Merged

upgrade to polkadot 1.5.0 #816

merged 21 commits into from
Feb 9, 2024

Conversation

simonsso
Copy link
Contributor

@simonsso simonsso commented Jan 5, 2024 •
edited
Loading

Regular release checklist

  • Verify merges
  • Upgrade spec_version in runtimes/eden/src/version.rs
  • cargo build --release
  • cargo test
  • Benchmarks compiles
  • Weights update or ignored
  • try-runtime
  • Run local test-net
  • File tickets if metadata changed

Known issues

  • Benchmarks for xcm disabled
  • Tryruntime failing
  • ORML upgrade needs review.

@simonsso simonsso force-pushed the iso/upgrade_to_polkadot_1_5_0 branch from 3a062fa to 7c3500f Compare January 5, 2024 07:25
@codecov Codecov
Copy link

codecov bot commented Jan 5, 2024 •
edited
Loading

Codecov Report

Attention: 649 lines in your changes are missing coverage. Please review.

Comparison is base (06cd3c8) 0.00% compared to head (8c1f75c) 67.01%.

Files Patch % Lines
runtimes/eden/src/weights/pallet_identity.rs 0.00% 77 Missing ⚠️
runtimes/eden/src/weights/pallet_uniques.rs 0.00% 60 Missing ⚠️
runtimes/eden/src/weights/pallet_preimage.rs 0.00% 52 Missing ⚠️
runtimes/eden/src/lib.rs 1.92% 51 Missing ⚠️
pallets/sponsorship/src/weights.rs 8.33% 44 Missing ⚠️
runtimes/eden/src/weights/pallet_xcm.rs 0.00% 44 Missing ⚠️
...imes/eden/src/weights/pallet_collator_selection.rs 0.00% 41 Missing ⚠️
runtimes/eden/src/weights/pallet_scheduler.rs 0.00% 37 Missing ⚠️
pallets/uniques/src/weights.rs 0.00% 36 Missing ⚠️
runtimes/eden/src/weights/pallet_multisig.rs 0.00% 32 Missing ⚠️
... and 12 more
Additional details and impacted files 
@@             Coverage Diff             @@
##           master     #816       +/-   ##
===========================================
+ Coverage        0   67.01%   +67.01%     
===========================================
  Files           0       49       +49     
  Lines           0    11066    +11066     
===========================================
+ Hits            0     7416     +7416     
- Misses          0     3650     +3650

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

aliXsed
aliXsed reviewed Jan 9, 2024
View reviewed changes
aliXsed
aliXsed reviewed Jan 9, 2024
View reviewed changes
aliXsed
aliXsed reviewed Jan 9, 2024
View reviewed changes
node/src/service.rs Outdated
@@ -251,6 +253,7 @@ where
relay_chain_interface: relay_chain_interface.clone(),
import_queue: params.import_queue,
net_config,
sybil_resistance_level: cumulus_client_service::CollatorSybilResistance::Unresistant,
Copy link
Contributor

@aliXsed aliXsed Jan 9, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we be resistant?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aliXsed
From the code here

pub enum CollatorSybilResistance {
	/// There is a collator-selection protocol which provides sybil-resistance,
	/// such as Aura. Sybil-resistant collator-selection protocols are able to
	/// operate more efficiently.
	Resistant,
	/// There is no collator-selection protocol providing sybil-resistance.
	/// In situations such as "free-for-all" collators, the network is unresistant
	/// and needs to attach more metadata to block announcements, relying on relay-chain
	/// validators to avoid handling unbounded numbers of blocks.
	Unresistant,
}

I read this as we should mark if we are resistant or not. So I think we should pick Unresistant here

aliXsed
aliXsed reviewed Jan 9, 2024
View reviewed changes
aliXsed
aliXsed reviewed Jan 9, 2024
View reviewed changes
aliXsed
aliXsed reviewed Jan 9, 2024
View reviewed changes
runtimes/eden/src/lib.rs Outdated
[pallet_contracts, Contracts]
[pallet_identity, Identity]
[pallet_membership, TechnicalMembership]
// [pallet_xcm, PolkadotXcm]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reminder pallet_xcm benchmark

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still TODO save this for 1.6

aliXsed
aliXsed reviewed Jan 9, 2024
View reviewed changes
runtimes/eden/src/xcm_config.rs Outdated
type ControllerOrigin = EnsureRoot<AccountId>;
type ControllerOriginConverter = XcmOriginToTransactDispatchOrigin;
type WeightInfo = cumulus_pallet_xcmp_queue::weights::SubstrateWeight<Self>;
type PriceForSiblingDelivery = ();
type PriceForSiblingDelivery = NoPriceForMessageDelivery<ParaId>;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reminder to review

@simonsso simonsso force-pushed the iso/upgrade_to_polkadot_1_5_0 branch from 47db6f4 to 5ef3389 Compare February 8, 2024 08:14
@simonsso simonsso changed the base branch from master to feature_integrate_upgrade February 9, 2024 04:03
This was referenced Feb 9, 2024
Closed
Closed
Closed
@simonsso simonsso merged commit ea140f3 into feature_integrate_upgrade Feb 9, 2024
10 checks passed
@simonsso simonsso deleted the iso/upgrade_to_polkadot_1_5_0 branch February 9, 2024 04:09
simonsso added a commit that referenced this pull request Mar 14, 2024
@simonsso @aliXsed
Upgrade polkadot-sdk (#813)
0e5767f 
* Upgrade to polkadot 1.1.0 (#800)
* Upgrade towards 1.1.0
* Update CI version
* polkadot 1.1 dependencies
* Merge updates for benchmarks
* upgrade to polkadot 1.2.1 (#804)
* Upgrade to 1.2.0  integrate PreImage Pallet
* Test cases remove deprecated calls
* Upgrade to polkadot 1.3.0
* ORML force update
* Benchmark tests
* Migration for pallet_uniques
* Remove Clippy Warnings
* Remove dead code
* Upgrade to polkadot 1.4.0 (#814)
* Remove ReachableDest
* XCM config
* Use define_benchmarks!
* upgrade to polkadot 1.5.0 (#816)
* Upgrade to 1.5.0
* Remove migrations completed in Spec 27
* Use release tag
* Upgrade to 1.6.0
* Upgrade calls to 1.6.0 API
* Dwellir hostname change
* Update weights
* Update service.rs and command.rs from latest template
* Workspace dependencies
* Get substrate from crates.io
* Storage migrations
* Reintegrate orml
* Silence warning
* Cargo.toml reformat
* Fix failing benchmarks
* XCM benchmarks
* Clippy
* CI srtool
* Update weights
* Use benchmark for reserve_asset_deposited()
* Use only two collators for dev nets
* SR tool version
* Update runtimes/eden/src/pallets_parachain.rs
* Update runtimes/eden/src/pallets_util.rs
* Update node/src/command.rs
* Use Polkadot ED
* Integrate proxy pallet
* Add pallet_proxy benchmarks
* Separate weights for all pallets
* Code cleanup
* Benchmarks
* Auto fmt
* Refactor benchmark script
* feat(nodle-parachain): use wasm executor
* Remove sponsorship migration
* Default ports Relay chain default rpc port different from parachain default port
* Docker example in Readme verified to work
* The docker example uses all necessary parameters. Is readable and runable at the same time.
* Set base delivery fee in DOT derived constant


close CHA-407
close #738
close #825 
close #824 

---------

Co-authored-by: Alex Sedighi <alex@nodle.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aliXsed aliXsed aliXsed left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@simonsso @aliXsed