Minor drive-by fixes #544
Merged
Minor drive-by fixes #544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As per its deprecation message: "This is a stub types definition. yaml provides its own type definitions, so you do not need this installed." I can verify that the latest yaml used ship its own type definitions.
This may take some time (especially on a slow connection) and we should surface to the user that the command is doing something rather than being stuck, as the `npm install` output is not surfaced to the user.
I know this is basically no-op since the point of the package is to group the protocol tests but it makes things a bit cleaner.
|
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/@types/yaml@1.9.7 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## development #544 +/- ##
==============================================
Coverage ? 52.62%
==============================================
Files ? 228
Lines ? 5317
Branches ? 835
==============================================
Hits ? 2798
Misses ? 2281
Partials ? 238 ☔ View full report in Codecov by Sentry. |
kanej
approved these changes
Feb 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discovered while I'm going through and starting to internalize the repository.
This PR:
I thought that these are not big enough to warrant separate PRs, so I decided to bundle these together.