Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump required VS Code version to ^1.86 #555

Merged
merged 3 commits into from
Apr 15, 2024
Merged

Bump required VS Code version to ^1.86 #555

merged 3 commits into from
Apr 15, 2024

Conversation

Xanewok
Copy link
Contributor

@Xanewok Xanewok commented Apr 15, 2024

This is required since we will not bundle Slang, requiring at least GLIBC 2.28, see NomicFoundation/slang#909.

Xanewok added 2 commits April 15, 2024 10:51
@Xanewok
chore: Require VS Code ^1.86
dd60634 
This bumps minimum required GLIBC to 2.28, which we use in Slang.
@Xanewok
fix: Adapt the test running in E2E to new VS Code task pick logic
2e08f3f 
It seems that it will not try to fuzzy match the items anymore but
rather rely on the user to pick the correct task type/group first,
before showing the relevant options.

This fixes the issue by explicitly specifying the "hardhat" task type.
@socket-security Socket Security
Copy link

socket-security bot commented Apr 15, 2024 •
edited
Loading

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@types/vscode@1.88.0 None 0 633 kB types
npm/nyc@15.1.0 environment, filesystem, unsafe Transitive: shell +112 13.4 MB coreyfarrell
npm/prettier-plugin-solidity@1.1.2 None +3 16 MB fvictorio
npm/prettier@2.5.1 environment, eval, filesystem, unsafe 0 21 MB sosukesuzuki
npm/qs@6.11.0 Transitive: eval +7 441 kB ljharb
npm/rimraf@3.0.2 filesystem 0 17.3 kB isaacs
npm/semver@7.5.4 None 0 93.4 kB npm-cli-ops
npm/serialize-error@8.1.0 None 0 10.3 kB sindresorhus
npm/sinon@12.0.1 Transitive: environment, eval +12 7.39 MB fatso83

🚮 Removed packages: npm/@types/vscode@1.75.1

View full report↗︎

@Xanewok
Copy link
Contributor Author

Xanewok commented Apr 15, 2024

"Add label to new issue" seems to be failing with 403, "Resource not accessible by integration". Maybe a bad key?

OmarTawfik
OmarTawfik approved these changes Apr 15, 2024
View reviewed changes
Copy link
Contributor

@OmarTawfik OmarTawfik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM on Slang side.

kanej
kanej approved these changes Apr 15, 2024
View reviewed changes
Copy link
Member

@kanej kanej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have taken a quick look and regenerated the PAT token for the add label workflow, but still get a failure.
I will track down what is causing that flow to fail, but it shouldn't block this PR.
I am happy with the vscode dep update.

@Xanewok Xanewok merged commit 1317f36 into NomicFoundation:development Apr 15, 2024
5 checks passed
@Xanewok Xanewok deleted the bump-vscode-version branch April 15, 2024 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OmarTawfik OmarTawfik OmarTawfik approved these changes

@kanej kanej kanej approved these changes

Assignees
No one assigned
Labels
None yet
Projects
hardhat-vscode
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Xanewok @kanej @OmarTawfik