chore: update CI uploading of codecov #613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Switch to github action, and away from npm package inline with codecov docs.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## development #613 +/- ##
===============================================
+ Coverage 54.38% 54.65% +0.26%
===============================================
Files 228 226 -2
Lines 5244 5187 -57
Branches 810 800 -10
===============================================
- Hits 2852 2835 -17
+ Misses 2154 2115 -39
+ Partials 238 237 -1 ☔ View full report in Codecov by Sentry. |
kanej
commented
Nov 14, 2024
| @@ -37,7 +37,7 @@ | |||
| "eslint": "eslint --max-warnings 0 \"./src/**/*.ts\" \"./test/**/*.ts\"", | |||
| "prettier": "prettier \"*.json\" \"src/**/*.{ts,js,md,json,yml}\" \"test/**/*.{ts,js,md,json,yml}\"", | |||
| "clean": "rimraf out .nyc_output coverage *.tsbuildinfo", | |||
| "test:codecov": "cross-env TS_NODE_FILES=true nyc --reporter=lcov mocha && codecov" | |||
There was a problem hiding this comment.
This script is now just about running tests with coverage and the appropriate reporter for codecov.
A follow on github action is responsible for the coverage upload.
kanej
commented
Nov 14, 2024
| @@ -58,7 +58,6 @@ | |||
| "@types/sinon": "10.0.6", | |||
| "c3-linearization": "0.3.0", | |||
| "chai": "4.3.4", | |||
| "codecov": "3.8.3", | |||
There was a problem hiding this comment.
The codecov package is no longer needed as upload is through the github action.
OmarTawfik
reviewed
Nov 15, 2024
OmarTawfik
approved these changes
Nov 15, 2024
Co-authored-by: Omar Tawfik <15987992+OmarTawfik@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch to an explicit github action for uploading code coverage files to codecov. We move away from the npm package inline with codecov docs: https://docs.codecov.com/docs/github-2-getting-a-codecov-account-and-uploading-coverage.