chore: add Sentry transaction monitoring to formatting #623
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Formatting has moved to the server side. We have added Sentry transaction monitoring to the top level `onDocumentFormatting` call. There are separate subspans on the Sentry transaction for Forge and Prettier. Resolves #622.
We should run under Node 20 as that is the version currently used by VSCode.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## development #623 +/- ##
===============================================
- Coverage 54.64% 54.52% -0.12%
===============================================
Files 226 226
Lines 5188 5199 +11
Branches 800 800
===============================================
Hits 2835 2835
- Misses 2116 2127 +11
Partials 237 237 ☔ View full report in Codecov by Sentry. |
|
@codecov [skip ci] We have added telemetry but not changed the tests. |
kanej
force-pushed
the
chore/add-sentry-to-formatting
branch
6 times, most recently
from
d526458 to
9842fde
Compare
kanej
force-pushed
the
chore/add-sentry-to-formatting
branch
from
9842fde to
8e43a1c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Formatting has moved to the server side. We have added Sentry transaction monitoring to the top level
onDocumentFormattingcall.There are separate subspans on the Sentry transaction for Forge and Prettier.
Resolves #622.