Skip to content

Commit

Permalink
Modify the infra test cargo command to run more tests. (#1218)
Browse files Browse the repository at this point in the history
I discovered this while looking into #1181. I tried adding a test case
to the query parsing tests, but found that none of them were getting
run. This PR fixes only that issue, nothing else about #1181.

Previously, the command used to run tests was `cargo nextest run
--workspace --all-features --lib --bins --examples --no-fail-fast`. This
command ended up skipping the tests in the `metaslang` packages. We can
run these as well by changing the command to `cargo nextest run
--workspace --exclude solidity_testing_perf --all-features --all-targets
--no-fail-fast`.

`--exclude solidity_testing_perf` is required because it tries to link
with callgrind, which will not be available on all platforms. It's
possible that this crash was the reason for the original restrictions in
the first place, but I don't know for sure. We can think about different
ways to conditionally run those tests in the future, if it's wanted.
  • Loading branch information
mjoerussell authored Feb 4, 2025
1 parent ee7e203 commit 87d0adc
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions crates/infra/cli/src/commands/test/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@ fn test_cargo() -> Result<()> {
.args(["nextest", "run"])
.flag("--workspace")
.flag("--all-features")
.flag("--tests")
.flag("--lib")
.flag("--bins")
.flag("--examples")
Expand Down

0 comments on commit 87d0adc

Please sign in to comment.