Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix whitespace in generated Wit interfaces #1225

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

mjoerussell
Copy link
Contributor

This PR updates our version of jco so that we can integrate this fix from wasm-tools (yes it's all about a transitive dependeny).

There was one small fix required here in order to use the new jco. In query.test.mts, the type of error in the test "query syntax error" was changed. Instead of being able to see the error message from error.message, we now have to check error.payload.message. All of the other fields that used to be on error are also moved to error.payload, but we weren't using any of those.

Closes #1188

…des all the current upstream changes from bytecodealliance/jco
…or objects. You now need to check `error.payload` for the error message instead of just checking `error`.
Copy link

changeset-bot bot commented Jan 21, 2025

⚠️ No Changeset found

Latest commit: c846c35

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@mjoerussell
Copy link
Contributor Author

This is ready once NomicFoundation/jco#13 is merged, then I'll update the version of jco in this branch back to nomic-enhancements-release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

broken indentation in generated TS definitions dpoc
1 participant