-
Notifications
You must be signed in to change notification settings - Fork 1
bug corrections #4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…pping_df, inter_new.json -> inter.json (?), minor N -> H in doc
| "metadata_path = '../data/Beauty/metadata.json'\n", | ||
| "\n", | ||
| "interactions_output_path = '../data/Beauty/inter_new.json'\n", | ||
| "interactions_output_path = '../data/Beauty/inter.json'\n", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
это вообще странная штука,
во-первых, даже тут https://zenodo.org/records/17351848 лежит и inter, и inter_new,
во-вторых, они различаются (посмотрел дифф), так что может быть в этом был какой-то смысл
minor: https://zenodo.org/records/17351848 отсюда без впн невозможно было что-то скачать (очень долго)
| "outputs": [], | ||
| "source": [ | ||
| "data = get_data(pl.from_pandas(df), item_ids_mapping)" | ||
| "data = get_data(pl.from_pandas(df), item_ids_mapping_df)" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
запустил, ругался, что пытаешься работать со словариком вместо df
в сигнатуре функции и в старой IRec версии тоже стояло с df
| if self._epoch_cnt is not None and epoch_num >= self._epoch_cnt: | ||
| LOGGER.debug( | ||
| 'Reached the maximum number of epochs ({}). Finish training'.format(self._epoch_cnt)) | ||
| break |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
без этого прокидывание max_epoch_cnt в конфиг не работало
| "source": [ | ||
| "data = get_data(pl.from_pandas(df), item_ids_mapping)" | ||
| "data = get_data(pl.from_pandas(df), item_ids_mapping_df)" | ||
| ] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
второй интересный момент, что я вообще не смог сбилдить эмбеддинги этим токенизатором, поймал
OSError: huggyllama/llama-7b does not appear to have a file named model-00001-of-00002.safetensors. Checkout 'https://huggingface.co/huggyllama/llama-7b/tree/main' for available files.
может, потому что запускал из datasphere, а нужен впн тут (файлы-то есть вроде там, только тяжелые очень),
запускал с такими зависимостями:
%pip install polars==1.33.1
%pip install numpy==2.3.3
%pip install pyarrow==17.0.0
%pip install pandas==2.2.3
%pip install transformers==4.56.1
%pip install sentencepiece==0.2.1
bug corrections: max epoch_cnt logic, item_ids_mapping -> item_ids_mapping_df, inter_new.json -> inter.json (?), minor N -> H in doc