Match back and front end user signup #342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
esteban-gs
approved these changes
May 23, 2023
There was a problem hiding this comment.
@rmwerner18 , thanks for working on this! I made a comment on changing one field, but otherwise it looks good to me. Approved once you apply the recommended change and remove the comment on the controller.
Comment on lines
93
to
96
| const citiesArray = ['Seattle', 'Detroit', 'Chicago', 'Nashville']; | ||
| return citiesArray.map((city) => { | ||
| return <MenuItem value={city}>{city}</MenuItem>; | ||
| }); |
There was a problem hiding this comment.
@rmwerner18 , for now, let's make this field a simple input element similar to zipcode. This will simplify our work.
| <Select | ||
| labelId="city-select" |
There was a problem hiding this comment.
Let's make this a regular input instead, so we don't have to provide a city for each state.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-Made bio, zip code, and interests inputs functional and included data in post request
-Fixed a bug that was happening with the city/state select inputs
-Post request to create user works (successfully creates user) but still throws an error for some reason
-Profile_image_url is not included in post request, currently image input is a file upload and not a text field for a url. This will probably require some more steps in order to store file as url
-Added interests from frontend to category seeds in backend, so that these interests can be saved
-Commented out email_verified check when logging in, to allow us to work around that for now