-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature/#15] 공통 컴포넌트 textfield UI 구현 #16
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaeulzzang
approved these changes
Jan 8, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
core/src/main/java/com/sopt/core/designsystem/component/textfield/NoostakTextField.kt
Outdated
Show resolved
Hide resolved
core/src/main/java/com/sopt/core/designsystem/component/textfield/NoostakTextField.kt
Show resolved
Hide resolved
core/src/main/java/com/sopt/core/designsystem/component/textfield/NoostakTextField.kt
Show resolved
Hide resolved
youjin09222
approved these changes
Jan 8, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
수고 많으셨습니다! 꼼꼼한 구현 덕분에 공통 컴포넌트로 활용하기 좋은 구조가 되었네요. 👍👍
core/src/main/java/com/sopt/core/designsystem/component/image/ProfileImagePicker.kt
Show resolved
Hide resolved
core/src/main/java/com/sopt/core/designsystem/component/image/ProfileImagePicker.kt
Show resolved
Hide resolved
core/src/main/java/com/sopt/core/designsystem/component/image/ProfileImagePicker.kt
Show resolved
Hide resolved
…-textfield-ui # Conflicts: # core/build.gradle.kts # core/src/main/java/com/sopt/core/designsystem/component/button/NoostakBottomButton.kt # core/src/main/java/com/sopt/core/extension/ContextExt.kt # core/src/main/java/com/sopt/core/util/permission/ImagePickerLaunchers.kt # core/src/main/java/com/sopt/core/util/permission/rememberGalleryLauncher.kt # presentation/src/main/java/com/sopt/presentation/groupCreate/GroupCreateRoute.kt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✅ 𝗖𝗵𝗲𝗰𝗸-𝗟𝗶𝘀𝘁
📌 𝗜𝘀𝘀𝘂𝗲𝘀
📎 𝗪𝗼𝗿𝗸 𝗗𝗲𝘀𝗰𝗿𝗶𝗽𝘁𝗶𝗼𝗻
📷 𝗦𝗰𝗿𝗲𝗲𝗻𝘀𝗵𝗼𝘁
💬 𝗧𝗼 𝗥𝗲𝘃𝗶𝗲𝘄𝗲𝗿𝘀
위와 같이 세 가지 케이스의 textfield 공통 컴포넌트 구현했슴다 @youjin09222 @twogarlic
사용하실 때 textFieldType에 따라 조금씩 textfield UI가 달라집니다
signup의 경우 하단에 "예) 홍길동" 텍스트 나타나게 하였고, calendar의 경우 글자 입력하더라도 x 아이콘 뜨지 않도록 했습니다
또한,
TextFieldType
자체에 placeholder text string으로 다 박아놨으니 설정 안하셔도 됩니다 제가 해둠요사용하실 때는 위와 같이 사용하시면 됩니다
기본 값 확인하시고 다른 건 알아서 호출할 때 인자로 넣어주세요 group 기준으로 기본 값 설정했거등요(확인하고 수정해야 하는 것 :
textFieldType
,value
,onValueChange
,placeholderColor
,textStyle
,shape
,cursorColor
,focusedBorderColor
,unfocusedWithInputBorderColor
,unfocusedBorderColor
,maxLength
)GUI 상 테두리 색이 총 3개 입니다. 1) 포커스 되었을 때 2) 포커스 되지 않았으며 아무 입력도 없을 때 3) 포커스 되지 않았으며 텍스트는 입력되었을 때. 각각이 아래의 변수입니다
focusedBorderColor
,unfocusedWithInputBorderColor
,unfocusedBorderColor
이외
ProfileImagePicker
,NoostakTopAppBar
,NoostakCloseAppBar
,NoostakBottomButton
,NoostakSnackBar
도 참고해서 사용하세요 @youjin09222 @twogarlic @gaeulzzang