[Feature/#1] : Project Initial Setting #2

gaeulzzang · 2024-10-04T09:02:04Z

✅ 𝗖𝗵𝗲𝗰𝗸-𝗟𝗶𝘀𝘁

merge할 브랜치의 위치를 확인해 주세요.(main❌/develop⭕)
리뷰가 필요한 경우 리뷰어를 지정해 주세요.
리뷰는 PR이 올라오면 최대한 빠르게 진행합니다.
P1 단계의 리뷰는 빠르게 확인 후 반영합니다.
Approve된 PR은 assigner가 머지하고, 수정 요청이 온 경우 수정 후 다시 push를 합니다.

📌 𝗜𝘀𝘀𝘂𝗲𝘀

closed [SETTING] : Project Initial Setting #1

📎 𝗪𝗼𝗿𝗸 𝗗𝗲𝘀𝗰𝗿𝗶𝗽𝘁𝗶𝗼𝗻

멀티모듈 세팅
기초 라이브러리 세팅
예제 파일 추가
MVI 세팅
CI/CD 세팅

📷 𝗦𝗰𝗿𝗲𝗲𝗻𝘀𝗵𝗼𝘁

Screen_recording_20241004_180012.mp4

💬 𝗧𝗼 𝗥𝗲𝘃𝗶𝗲𝘄𝗲𝗿𝘀

local.properties 파일에 base.url="https://reqres.in" 넣어주세요!

…into feature/#1-project-initial-setting

twogarlic

가을이 친구들 왕많네 고생해써어어ㅓ🥳

youjin09222

너무 고생했어ㅓㅓㅓ

Eonji-sw

엄마 피곤해요..

Eonji-sw · 2024-11-15T04:50:17Z

app/src/main/java/com/sopt/noostak/di/RetrofitModule.kt

+    fun provideLoggingInterceptor(): HttpLoggingInterceptor {
+        val loggingInterceptor = HttpLoggingInterceptor { message ->
+            when {
+                message.isJsonObject() -> Timber.d(JSONObject(message).toString(4))


P3 : 4는 가독성 때문에 넣은거죠?

멀라여 앱잼 코드 복붙했는데여 ㅎㅎ

Eonji-sw · 2024-11-15T04:55:36Z

core/src/main/java/com/sopt/core/designsystem/component/dialog/BaseDialog.kt

+                    .padding(top = 18.dp, bottom = 16.dp)
+                    .padding(horizontal = 16.dp),


P2 : 추후 GUI 보고 자주 사용하는 padding 값은 (ex. 하단 버튼과 배경 간격, 다이얼로그 버튼 간격 등...) dimens로 빼면 좋을 것 같네요!

오 좋은 생각이네요!! 디자인 확정되면 그때 dimens로 빼볼게유

Eonji-sw · 2024-11-15T04:57:11Z

core/src/main/java/com/sopt/core/designsystem/theme/Type.kt

P3 : 제대로 컴포즈 글꼴 설정하는거 복잡하던데~ 쩝..

찾아보니까 진짜 복잡하네... 폰트는 언지가 하자^^

Eonji-sw · 2024-11-15T04:58:02Z

core/src/main/res/font/pretendard_light.otf

P3 : otf로 하신 이유는 먼가요~?

ttf랑 otf 차이가 1도 없다길래 그냥 otf 넣었어욤

Eonji-sw · 2024-11-15T05:08:43Z

data/src/main/java/com/sopt/data/service/ExampleApiService.kt

+interface ExampleApiService {
+    @GET("/$API/$USERS")
+    suspend fun getUsers(
+        @Query("page") page: Int


P2 :

Suggested change

@Query("page") page: Int

import com.sopt.data.service.ApiKeyStorage.PAGE

@Query(PAGE) page: Int

헉스바뤼따쉬 피드백 감사띠

Eonji-sw · 2024-11-15T05:17:42Z

gradle/libs.versions.toml

+retrofit-core = { group = "com.squareup.retrofit2", name = "retrofit", version.ref = "retrofit" } # Retrofit 네트워킹 라이브러리
+retrofit-kotlin-serialization = { group = "com.jakewharton.retrofit", name = "retrofit2-kotlinx-serialization-converter", version.ref = "retrofit-kotlinx-serialization-json" } # Retrofit Kotlinx Serialization 변환기
+okhttp-logging = { group = "com.squareup.okhttp3", name = "logging-interceptor", version.ref = "okhttp" } # OkHttp 로깅 인터셉터


P2 : 이런 식으로 같이 dependency 추가해서 사용할 경우가 많다면 bundle로 묶어서 한번에 호출하는 것도 편리할 것 같네용

넴 번들로 수정할게유

Eonji-sw · 2024-11-15T05:19:13Z

presentation/build.gradle.kts

+    implementation(libs.retrofit.core)
+    implementation(libs.retrofit.kotlin.serialization)
+    implementation(libs.okhttp.logging)


P3 :

Suggested change

implementation(libs.retrofit.core)

implementation(libs.retrofit.kotlin.serialization)

implementation(libs.okhttp.logging)

implementation(libs.bundles.retrofit)

이런 느낌으로 바꿀 수도 있을듯? 그냥 갠적인 의견~

Eonji-sw · 2024-11-15T05:27:02Z

presentation/src/main/java/com/sopt/presentation/calendar/navigation/CalendarNavigation.kt

P3 : 응애 엄마 설명해줘~

NavGraphBuilder에 캘린더 화면 경로 등록하구, 캘린더 화면으로 이동하는 navigateCalendar 함수 NavController에 등록하는 코드에여

Eonji-sw · 2024-11-15T05:45:13Z

presentation/src/main/java/com/sopt/presentation/example/ExampleViewModel.kt

+                onFailure = {
+                    _state.value =
+                        _state.value.copy(followers = UiState.Failure(it.message.toString()))
+                    _sideEffects.emit(ExampleSideEffect.ShowToast(R.string.server_failure))


P3 : toast 메시지 text는 UI 관련이라.. viewModel에서는 UI 상태에 대한 관리만 해주고 액티비티에서 알맞은 toast 메시지 호출 방식이 분리 목적에서 맞지 않나라는 글을 본 적이 있는데 컴포즈 입장에서는 어떻게 생각하는지요~?

Composition이 성공적으로 완료되었을 때 부수 효과를 인텐트로 실행하려면 SideEffect에 Toast에 들어갈 메시지를 담아 보내더라구요... 고정 UI를 제외한 요소들은 뷰모델에 작성해주는게 MVI에 맞는 방법인 것 같습니답 😭

gaeulzzang added 5 commits October 4, 2024 14:49

[FEAT] project init setting

e603b40

Merge branch 'main' of https://github.com/Noostak/Noostak_Android

71d16d8

#1 [FEAT] changes in gradle, misc.xml

df0885e

#1 [ADD] add base components

0b82df9

Merge branch 'develop' of https://github.com/Noostak/Noostak_Android …

3bac49b

…into feature/#1-project-initial-setting

gaeulzzang added ⚙️ [SETTING] 세팅 🍂 가을 가응가 labels Oct 4, 2024

gaeulzzang requested review from twogarlic and Eonji-sw October 4, 2024 09:02

gaeulzzang self-assigned this Oct 4, 2024

gaeulzzang requested a review from youjin09222 October 4, 2024 14:33

#1 [MOD] modify gradle namespace

c9e9d32

gaeulzzang requested a review from a team as a code owner October 4, 2024 14:38

#1 [ADD] add gitignore

5f444ea

twogarlic approved these changes Nov 14, 2024

View reviewed changes

youjin09222 approved these changes Nov 15, 2024

View reviewed changes

Eonji-sw approved these changes Nov 15, 2024

View reviewed changes

gaeulzzang added 2 commits November 15, 2024 21:37

#1 [REFACTOR] 코드 리뷰 반영

a546c7b

Apply .gitignore

d15ff60

gaeulzzang merged commit 3ea912a into develop Nov 15, 2024
1 check passed

gaeulzzang deleted the feature/#1-project-initial-setting branch December 27, 2024 13:57

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Feature/#1] : Project Initial Setting #2

[Feature/#1] : Project Initial Setting #2

gaeulzzang commented Oct 4, 2024

twogarlic left a comment

youjin09222 left a comment

Eonji-sw left a comment

Eonji-sw Nov 15, 2024

gaeulzzang Nov 15, 2024

Eonji-sw Nov 15, 2024

gaeulzzang Nov 15, 2024

Eonji-sw Nov 15, 2024

gaeulzzang Nov 15, 2024 •

edited

Loading

Eonji-sw Nov 15, 2024

gaeulzzang Nov 15, 2024

Eonji-sw Nov 15, 2024 •

edited

Loading

gaeulzzang Nov 15, 2024

Eonji-sw Nov 15, 2024 •

edited

Loading

gaeulzzang Nov 15, 2024

Eonji-sw Nov 15, 2024

Eonji-sw Nov 15, 2024

gaeulzzang Nov 15, 2024

Eonji-sw Nov 15, 2024 •

edited

Loading

gaeulzzang Nov 15, 2024

		.padding(top = 18.dp, bottom = 16.dp)
		.padding(horizontal = 16.dp),

-        @Query("page") page: Int
+import com.sopt.data.service.ApiKeyStorage.PAGE
+        @Query(PAGE) page: Int

[Feature/#1] : Project Initial Setting #2

[Feature/#1] : Project Initial Setting #2

Conversation

gaeulzzang commented Oct 4, 2024

✅ 𝗖𝗵𝗲𝗰𝗸-𝗟𝗶𝘀𝘁

📌 𝗜𝘀𝘀𝘂𝗲𝘀

📎 𝗪𝗼𝗿𝗸 𝗗𝗲𝘀𝗰𝗿𝗶𝗽𝘁𝗶𝗼𝗻

📷 𝗦𝗰𝗿𝗲𝗲𝗻𝘀𝗵𝗼𝘁

💬 𝗧𝗼 𝗥𝗲𝘃𝗶𝗲𝘄𝗲𝗿𝘀

twogarlic left a comment

Choose a reason for hiding this comment

youjin09222 left a comment

Choose a reason for hiding this comment

Eonji-sw left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

gaeulzzang Nov 15, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Eonji-sw Nov 15, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Eonji-sw Nov 15, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Eonji-sw Nov 15, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

gaeulzzang Nov 15, 2024 •

edited

Loading

Eonji-sw Nov 15, 2024 •

edited

Loading

Eonji-sw Nov 15, 2024 •

edited

Loading

Eonji-sw Nov 15, 2024 •

edited

Loading