No bug: Basic sanity tests for sonar GPU logic

tests/amd-gpu.sh

@@ -0,0 +1,26 @@
+#!/usr/bin/env bash
+#
+# Check that `sonar sysinfo` can detect an AMD GPU if it ought to (based on info from the file
+# system).  This test must be run on a node with such a device to have any effect, hence will not be
+# effective in the github runner.
+#
+# Requirement: the `jq` utility.
+
+set -e
+if [[ ! -e /sys/module/amdgpu ]]; then
+    echo "No device"
+    exit 0
+fi
+
+( cd .. ; cargo build )
+output=$(../target/debug/sonar sysinfo)
+numcards=$(jq .gpu_cards <<< $output)
+if [[ ! ( $numcards =~ ^[0-9]+$ ) ]]; then
+    echo "Bad output from jq: <$numcards>"
+    exit 1
+fi
+if (( $numcards == 0 )); then
+    echo "Number of cards should be nonzero"
+    exit 1
+fi
+echo "OK"

tests/nvidia-gpu.sh

@@ -0,0 +1,26 @@
+#!/usr/bin/env bash
+#
+# Check that `sonar sysinfo` can detect an NVIDIA GPU if it ought to (based on info from the file
+# system).  This test must be run on a node with such a device to have any effect, hence will not be
+# effective in the github runner.
+#
+# Requirement: the `jq` utility.
+
+set -e
+if [[ ! -e /sys/module/nvidia ]]; then
+    echo "No device"
+    exit 0
+fi
+
+( cd .. ; cargo build )
+output=$(../target/debug/sonar sysinfo)
+numcards=$(jq .gpu_cards <<< $output)
+if [[ ! ( $numcards =~ ^[0-9]+$ ) ]]; then
+    echo "Bad output from jq: <$numcards>"
+    exit 1
+fi
+if (( $numcards == 0 )); then
+    echo "Number of cards should be nonzero"
+    exit 1
+fi
+echo "OK"

tests/run_tests.sh

@@ -14,7 +14,8 @@ fi
 # keep tests alphabetical
 # later we could just iterate over all scripts that end with .sh
 # and are not this script
-for test in command-line \
+for test in amd-gpu \
+                command-line \
                 exclude-commands \
                 exclude-system-jobs \
                 exclude-users \
@@ -24,6 +25,7 @@ for test in command-line \
                 load \
                 lockfile \
                 min-cpu-time \
+                nvidia-gpu \
                 ps-syntax \
                 rollup \
                 rollup2 \