New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #88 - spawn subprograms directly, not via shell #164

Merged

bast merged 1 commit into NordicHPC:main from lars-t-hansen:w-88-exec-not-system

Apr 10, 2024

Collaborator

lars-t-hansen commented Apr 10, 2024

Improves efficiency, makes accidents harder, and sets us up for getting rid of the subprocess library.


          Fix NordicHPC#88 - spawn subprograms directly, not via shell

c4bb676

lars-t-hansen marked this pull request as ready for review

April 10, 2024 06:37

Collaborator Author

lars-t-hansen commented Apr 10, 2024

Passes tests on AMD and NVIDIA hardware too, so this looks good to go.

lars-t-hansen requested a review from bast

April 10, 2024 06:38

bast merged commit fca62c5 into NordicHPC:main

1 check passed

lars-t-hansen deleted the w-88-exec-not-system branch

April 11, 2024 06:15

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet