Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit test #20

Merged
merged 99 commits into from
Aug 31, 2023
Merged

Unit test #20

merged 99 commits into from
Aug 31, 2023

Conversation

Laura2305
Copy link
Contributor

No description provided.

Copy link
Collaborator

@alexjaffray alexjaffray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I'll go through and add some commits today, then let me know if you're alright with the changes

# API

This page contains documentation of the public API of MRINavigator. In the Julia REPL one can access this documentation by entering the help mode with ? and then writing the function for which the documentation should be shown.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add the actual command in code: ? <my-function-name>

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@alexjaffray
Copy link
Collaborator

@Laura2305 I've done my review of this branch, if it goes through the CI with my changes, please review them and let me know when I can approve and merge

@Laura2305
Copy link
Contributor Author

@alexjaffray I have reviewed your changes and everything looks good to me. I'd first merge the documentation branch into setup (pull request #21) and then everything into main.

@alexjaffray
Copy link
Collaborator

@Laura2305 this should pass CI. Once it does, I will merge into main

@alexjaffray alexjaffray merged commit 49c4114 into main Aug 31, 2023
3 checks passed
@Laura2305 Laura2305 deleted the setup branch September 9, 2023 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants