Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Smallfixes #43

Merged
merged 2 commits into from
Jan 11, 2024
Merged

Smallfixes #43

merged 2 commits into from
Jan 11, 2024

Conversation

Laura2305
Copy link
Contributor

@Laura2305 Laura2305 commented Jan 9, 2024 •
edited
Loading

Small fixes:

  • Add aligned and interpolated respiratory trace to the output of the nav unwrap pipeline
  • Bug fix for empty noise matrix

@Laura2305
Copy link
Contributor Author

Hi @alexjaffray, This is ready to be reviewed and merged.

alexjaffray
alexjaffray approved these changes Jan 10, 2024
View reviewed changes
src/NavData.jl
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea to have timing information in the navigator output

src/Navigator.jl
weights[:,ii,:,:] = navabs[:,ii,:,:] ./ noisestd[1,ii]
end
weights = ones(size(navabs))
if !any(noisestd .== 0)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we know for sure an explicit value of 0 is always given? I.e it couldn't be 1e-31 or something by accident?

@Laura2305 Laura2305 merged commit 3b72bf2 into main Jan 11, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexjaffray alexjaffray alexjaffray approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Laura2305 @alexjaffray