Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add FFTW version compatibility #47

Merged
merged 4 commits into from
Mar 1, 2024
Merged

add FFTW version compatibility #47

merged 4 commits into from
Mar 1, 2024

Conversation

Laura2305
Copy link
Contributor

No description provided.

Copy link

codecov bot commented Feb 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.96%. Comparing base (4df1c24) to head (5b5e8b2).
Report is 11 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #47   +/-   ##
=======================================
  Coverage   70.96%   70.96%           
=======================================
  Files           9        9           
  Lines         620      620           
=======================================
  Hits          440      440           
  Misses        180      180           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Laura2305
Copy link
Contributor Author

@alexander, I think we can merge this. The precompilation errors on nightly but there's a PR open on CSV.jl regarding this: JuliaData/CSV.jl#1124

The error they report is the same we get in the CI.

@alexjaffray
Copy link
Collaborator

Looks good to me, as long as the error on nightly isn't a result of our programming I think it's alright to merge. I'll approve, you can merge when you like.

Copy link
Collaborator

@alexjaffray alexjaffray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, hopefully the CSV and nightly issue gets fixed so we get the green checkmark back soon

@Laura2305 Laura2305 merged commit ca6097c into main Mar 1, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants