#201 delete photo tag (Fetch more recent codebase)#295
Open
Conversation
Old branch wasn't letting me fetch new codebase so had to make a new one.
Arushi55
requested changes
Feb 6, 2025
Contributor
Arushi55
left a comment
There was a problem hiding this comment.
Looks mostly good. My only issue is the double call to the accessor seems unnecessary.
ethanszeto
reviewed
Feb 6, 2025
Contributor
Author
|
For the ErrorPhotoTagNotFound(), I opt for a nested try-catch in the controller bc wasn't sure if throwing it in accessor would be bad design, but if not, I can edit again. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Old branch wasn't letting me fetch new codebase so had to make a new one.
Pull Request
Brief Summary
Questions / Considerations for the Future
-
API Changes
Database Changes
-
New Tests
Closes #201