307 move password hashing to new auth file#309
Open
stephanie-xu wants to merge 4 commits intomainfrom
Open
Conversation
ethanszeto
requested changes
Apr 2, 2025
Member
ethanszeto
left a comment
ethanszeto
left a comment
There was a problem hiding this comment.
Looks good, just one extra thing that could be cool
Comment on lines
+20
to
+23
| static async hash(password) { | ||
| const encrypted = await bcrypt.hash(password, 10); | ||
| return encrypted; | ||
| } |
Member
There was a problem hiding this comment.
Maybe add random salting here:
The way the bcrypt works is that you get to define the "salting" you do (aka. random string). Right now we don't really generate a random salt, making the outcome predictable. Try to use genSalt in order to bolster the security of passwords
Member
There was a problem hiding this comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Brief Summary
Questions / Considerations for the Future
API Changes
-
Database Changes
-
New Tests
Closes #307