Skip to content

moved login token signing to LoginToken class#312

Open
rbessin wants to merge 1 commit intomainfrom
#306-Move-Login-Token-Signing-to-new-Auth-file
Open

moved login token signing to LoginToken class#312
rbessin wants to merge 1 commit intomainfrom
#306-Move-Login-Token-Signing-to-new-Auth-file

Conversation

@rbessin
Copy link

@rbessin rbessin commented Nov 24, 2025

Pull Request

There are changes (adding res to signatures) from my other ticket which shouldn't be an issue but I couldn't manage to get rid of them since they were in the same file as the changes for this ticket. Hope that isn't an issue. Let me know.

Brief Summary

  • Created new loginToken class with static generate method that handles JWT token signing
  • Generate returns the signed token and cookie configuration options
  • Updated UserController.login() to use LoginToken.generate().

Questions / Considerations for the Future

  • Should other cookie options have default values like secure and sameSite? Should they passed in through the cookie options directly?
  • Should there be tests for LoginToken.generate()?

Closes #306

@rbessin rbessin requested review from a team as code owners November 24, 2025 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Move Login Token Signing to new Auth file

1 participant