Open
Conversation
ethanszeto
requested changes
Feb 25, 2026
Member
ethanszeto
left a comment
ethanszeto
left a comment
There was a problem hiding this comment.
- Small thing about spaces included in the link itself -- looks a little bit strange.
- What happens if a quote is a new paragraph? or between paragraphs? Right now the quote is embedded into the surrounded body paragraphs, however, it would be weird if the link spanned two distinct paragraphs and merged then.
| if (item.contentType === "link") { | ||
| paragraphSegments.push({ | ||
| type: "link", | ||
| text: " " + item.content + " ", |
Member
There was a problem hiding this comment.
It looks kinda funky with the rbuffespaces being incl uded in the text itself
Contributor
Author
There was a problem hiding this comment.
yeah, the links look weird, but the current data doesn't have spaces, so they need to be added somewhere.
Also, with the quotes, it's in a div, so the new line is automatic.
Links don't span paragraphs to my understanding.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Front End Pull Request
Brief Summary