Open
Conversation
ethanszeto
requested changes
Oct 2, 2025
Member
ethanszeto
left a comment
ethanszeto
left a comment
There was a problem hiding this comment.
Hey Seleena, I'm still getting a lot of height and visual bugs for the carousel. Vertical components aren't being fully displayed correctly
Furthermore, try to only use components from the DS when possible, like <Box> is a <div> wrapper, etc.
Also try to only use colors in the DS for stories. Not a huge deal, though.
Are you using CardItem? I think it might be a good idea to have as a child wrapper, to give you more control over your carousel input elements.
Try to fix these visual changes first and I'll take a closer look at the code afterwards.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Front End Pull Request
Brief Summary
Implements a flexible and reusable Carousel component. The carousel supports both horizontal and vertical scroll orientations (independent of content layout), single or multiple items per view, autoplay functionality with pause-on-hover, navigation arrows, and loop behavior. It accepts any React children (cards, images, videos, etc).
Questions / Considerations for the Future
It would be interesting to consider the need/want of keyboard navigation (using the arrow keys) and potentially swipe/touch (mobile devices).
Image of changes
Closes #53