Open
Conversation
Arushi55
requested changes
Oct 27, 2025
Comment on lines
21
to
22
| profileImage: string; | ||
| bannerImage: string; |
Contributor
There was a problem hiding this comment.
These should also be able to use the image upload component (this is available if you merge article-submission into your branch. That way people can either provide a url or just upload an image from their device. As in, the type should be string | File and then in the form, allow both text box or image upload.
| <GridCol span={1}> | ||
| <FormField<ProfileFormValues> | ||
| name="bannerImage" | ||
| rules={{ required: "Banner image URL is required" }} |
Contributor
There was a problem hiding this comment.
Are we requiring this and the profile image?
| pattern: { value: /^\S+@\S+$/i, message: "Please enter a valid email" }, | ||
| }} | ||
| > | ||
| <TextInput label="Email *" placeholder="name@northeastern.edu" className="w-full" /> |
Contributor
There was a problem hiding this comment.
It'd be neat if people didn't have to enter @northeastern.edu because we already had it there for them.
Arushi55
requested changes
Jan 25, 2026
Contributor
Arushi55
left a comment
Arushi55
left a comment
There was a problem hiding this comment.
Minor changes to ensure consistent use of the design system.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Front End Pull Request
Brief Summary
Created the Private Profile page based off the Public Profile page. Click on the edit button to see the changes.
Questions / Considerations for the Future
Image of changes
Public:
Private:
Private After Edits
Closes #56